Integrate unified base mode color and helper function #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made some changes in e-mission-common, can you update this PR?
|
…de_colors to base_modes
|
@JGreenlee sounds good, just made those changes in the e-mission-phone PR! |
-remove unused imports -fix missing type "BaseModeKey" --this was previously `keyof typeof BASE_MODES`. Now that BASE_MODES is in e-mission-common and is defined as a `dict`, Typescript has a harder time picking up on the types. Keeping as `string` for now.
modeColors is not in diaryHelper anymore; must be accessed from e-mission-common's `base_modes`
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1164 +/- ##
==========================================
- Coverage 30.36% 30.04% -0.33%
==========================================
Files 118 118
Lines 5256 5196 -60
Branches 1106 1162 +56
==========================================
- Hits 1596 1561 -35
+ Misses 3658 3631 -27
- Partials 2 4 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
shankari
requested changes
Aug 17, 2024
There are no usages of this
|
Also seen on LabelDetailsScreen with 
|
shankari
approved these changes
Aug 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated
e-mission-commonPR which unifies the base mode colors and a helper function. Went through the code base and swapped all instances ofgetBaseModeByKey()withbase_mode_colors.get_base_mode_by_key(). I also convertedmodeColorsandBaseModesindiaryHelper.tsto now use our unified functions. IndiaryHelper.tsI also had to add in types for one of the functions as I was getting a typescript "type unknown of distA/distB" error. I guess when I removedgetBaseModeByKey(), the type inference couldn't figure out that they were numbers so it was throwing that error.Testing Done
I went through each component that I converted
getBaseModeByKey()forbase_mode_colors.get_base_mode_by_key()and tested it out to make sure it still worked properly.