convert to geojson with tracejson #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
hm.. it is true that I don't actually check for the timestamps. Let me see whether the UI uses them. If so, I should add that to the tests and we should ensure that the |
|
Unfortunately, we do include |
|
@nlehuby thanks for fixing the |
… into nlehuby-tracejson
The `tracejson` format has some open questions around how to represent start and end times. Should they also be milliseconds? What should the labels be, etc? In order to avoid dealing with those issues right now, we return both "times" and "timestamps". The "times" retain backward compatibility with existing code; the "timestamps" ensure that it is valid tracejson. We will revisit this after the paper on mobility standards: e-mission/e-mission-docs#542 (comment)
shankari
approved these changes
Aug 2, 2020
jf87
pushed a commit
to jf87/e-mission-server
that referenced
this pull request
Jun 21, 2021
convert to geojson with tracejson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of e-mission/e-mission-docs#542
There are some fixtures that hold exported data (
*.ground_truthfiles inemissions/tests/data) that could be updated accordingly. But as there are no test about these properties, I'm not sure how valuable it is.