🔥 remove dependencies, upgrade the base image and remove unused auth methods #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That was a hacky branch which we are now ready to remove We have removed the branch, we are now removing the automatic build from the branch This is a partial fix for e-mission/e-mission-docs#855
We currently only support token-based authentication, either using a token generated on the phone (`skip`) or pre-generated (`token_list`). Removing the google auth and openid authentication methods, and the python package used for the auth to slim down our dependency profile Testing done: - Launched server with changes - Logged in via the UI
…itch to jq - Previously commented out dependencies were "deprecated"; remove them - Comment out other lines that don't seem to be needed - e.g. editors; these are now deprecated and will be removed in the next edit - switch to jq instead of sed to support more complex mongoDB URLs and be more consistent with the internal server build - install wget in addition to curl so we don't need to use `apt-get update` in the internal repo; we should be able to remove it in the next iteration if we are not using it. Testing done: - Launched the container as part of a docker-compose - Checked the logs and the server started up - Tried to connect to the server using a browser, was redirected to the notfound URL - Tried to connect to the server using the phone app, got a 403 error (since we hadn't loaded any data)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
join_redirect_to_staticbranch