Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 remove dependencies, upgrade the base image and remove unused auth methods #906

Merged
merged 3 commits into from
Apr 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .docker/docker_start_script.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@
echo ${DB_HOST}
if [ -z ${DB_HOST} ] ; then
local_host=`hostname -i`
sed "s_localhost_${local_host}_" conf/storage/db.conf.sample > conf/storage/db.conf
jq --arg db_host "$local_host" '.timeseries.url = $db_host' conf/storage/db.conf.sample > conf/storage/db.conf
else
sed "s_localhost_${DB_HOST}_" conf/storage/db.conf.sample > conf/storage/db.conf
jq --arg db_host "$DB_HOST" '.timeseries.url = $db_host' conf/storage/db.conf.sample > conf/storage/db.conf
fi
cat conf/storage/db.conf

Expand Down Expand Up @@ -38,4 +38,4 @@ fi
source setup/activate.sh

# launch the webapp
./e-mission-py.bash emission/net/api/cfc_webapp.py
./e-mission-py.bash emission/net/api/cfc_webapp.py
2 changes: 1 addition & 1 deletion .github/workflows/image_build_push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ name: docker image
# events but only for the master branch
on:
push:
branches: [ master, gis-based-mode-detection, join_redirect_to_static ]
branches: [ master, gis-based-mode-detection ]


# Env variable
Expand Down
25 changes: 11 additions & 14 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,32 +1,29 @@
# python 3
FROM ubuntu:focal
FROM ubuntu:jammy

MAINTAINER K. Shankari (shankari@eecs.berkeley.edu)

WORKDIR /usr/src/app

RUN apt-get update
RUN apt-get install -y curl
RUN apt-get install -y git
RUN apt-get -y -qq update
RUN apt-get install -y -qq curl
RUN apt-get install -y -qq wget
# RUN apt-get install -y git

# install nano and vim for editing
RUN apt-get -y install nano vim
# RUN apt-get -y install nano vim

# install jq to parse json within bash scripts
RUN curl -o /usr/local/bin/jq http://stedolan.github.io/jq/download/linux64/jq && \
chmod +x /usr/local/bin/jq

# cleanup
RUN apt-get -y remove --purge build-essential
RUN apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

COPY . .

# ARG SERVER_REPO
# ENV SERVER_REPO=${SERVER_REPO:-https://github.com/e-mission/e-mission-server.git}

# ARG SERVER_BRANCH
# ENV SERVER_BRANCH=${SERVER_BRANCH:-master}

# ADD clone_server.sh /clone_server.sh
RUN chmod u+x ./.docker/setup_config.sh
# ADD index.html /index.html

# # This clone puts the server code into the image, not the container
RUN bash -c "./.docker/setup_config.sh"
Expand All @@ -41,4 +38,4 @@ RUN chmod u+x ./.docker/docker_start_script.sh

EXPOSE 8080

CMD ["/bin/bash", "./.docker/docker_start_script.sh"]
CMD ["/bin/bash", "./.docker/docker_start_script.sh"]
8 changes: 0 additions & 8 deletions emission/net/auth/auth.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,6 @@ def getAuthMethod(methodName):
import emission.net.auth.secret as enar
logging.debug("methodName = secret, returning %s" % enar.SecretMethod)
return enar.SecretMethod()
elif methodName == "openid_auth":
import emission.net.auth.openid_auth as enao
logging.debug("methodName = openid_auth, returning %s" % enao.OpenIDAuthMethod)
return enao.OpenIDAuthMethod()
elif methodName == "google_auth":
import emission.net.auth.google_auth as enag
logging.debug("methodName = google_auth, returning %s" % enag.GoogleAuthMethod)
return enag.GoogleAuthMethod()
elif methodName == "token_list":
import emission.net.auth.token_list as enat
logging.debug("methodName = token_list, returning %s" % enat.TokenListMethod)
Expand Down
71 changes: 0 additions & 71 deletions emission/net/auth/google_auth.py

This file was deleted.

64 changes: 0 additions & 64 deletions emission/net/auth/openid_auth.py

This file was deleted.

1 change: 0 additions & 1 deletion setup/environment36.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ dependencies:
- cheroot=9.0.0
- future=0.18.3
- geojson=2.5.0
- google-auth=2.16.0
- jsonpickle=3.0.0
- numpy=1.24.2
- pandas=1.5.3
Expand Down