Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update php and symfony requirements #30

Closed
wants to merge 2 commits into from
Closed

Update php and symfony requirements #30

wants to merge 2 commits into from

Conversation

vkhramtsov
Copy link
Contributor

Fixes #29

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 98.824% when pulling e65f4fa on vkhramtsov:feature-remove-old-php-versions-add-newest into 9e81956 on e-moe:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 98.824% when pulling e65f4fa on vkhramtsov:feature-remove-old-php-versions-add-newest into 9e81956 on e-moe:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 98.824% when pulling e65f4fa on vkhramtsov:feature-remove-old-php-versions-add-newest into 9e81956 on e-moe:master.

@coveralls
Copy link

coveralls commented Mar 10, 2019 •
edited

Coverage Status

Coverage increased (+0.02%) to 98.824% when pulling e0caa2f on vkhramtsov:feature-remove-old-php-versions-add-newest into 83ed405 on e-moe:master.

@e-moe
Copy link
Owner

e-moe commented Mar 11, 2019

@vkhramtsov , thanks for contribution! Please add PHP 7.3 support and avoid removing deprecations in current PR. Deprecations will be removed separately in next major release.

@vkhramtsov
Copy link
Contributor Author

vkhramtsov commented Mar 11, 2019 •
edited

I would like to remove hhvm from builds as well, because newest version of composer fails on it (see https://travis-ci.org/e-moe/guzzle6-bundle/builds/504404581). I'm going to revert part of this PR and create new with removing deprecations

@vkhramtsov
Copy link
Contributor Author

New PR #31 for adding php 7.3 created

@e-moe e-moe force-pushed the master branch 6 times, most recently from a5a0a82 to a51abff Compare February 27, 2020 09:45
@vkhramtsov vkhramtsov closed this Jun 16, 2020
@vkhramtsov vkhramtsov deleted the feature-remove-old-php-versions-add-newest branch June 16, 2020 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supported PHP versions
3 participants
@vkhramtsov @coveralls @e-moe