Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q: how to replace pager for bootstrap4 #2962

Closed
Jimmi08 opened this issue Jan 8, 2018 · 4 comments
Closed

Q: how to replace pager for bootstrap4 #2962

Jimmi08 opened this issue Jan 8, 2018 · 4 comments
Assignees
Labels
type: enhancement An improvement or new feature request type: question An ask about behavior that is not found documented anywhere

Comments

@Jimmi08
Copy link
Contributor

Jimmi08 commented Jan 8, 2018

pager is dropped in bootstrap4

This is actual output:
return '<ul class="pager"><li><a href="'.$url.'">'.$total.'</a></li></ul>';

Dropped the .pager component entirely as it was little more than customized outline buttons.

It should be replaced something like this:
return '<a class="btn btn-outline-primary" href="'.$url.'">'.$total.'</a>';

My suggestion:
return '<a class="pager-button btn btn-outline-primary" href="'.$url.'">'.$total.'</a>';

  • adding class pager-button to be able override
    pager-button.btn.btn-outline-primary in css if there is needed diffarent colour or anything.

Of course, only for BOOTSTRAP==4.

@Moc Moc added type: enhancement An improvement or new feature request type: question An ask about behavior that is not found documented anywhere labels Jan 8, 2018
@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Jan 9, 2018

Closing in favor #2969

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Jun 15, 2019

@Moc this one too: $DOWNLOAD_TEMPLATE['view']['nextprev']

@Moc Moc reopened this Jun 15, 2019
@Moc Moc self-assigned this Jun 15, 2019
@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Jun 15, 2019

@Moc I did quick fix this way, but not nested with bootstrap3 and padding bottom is too small.

$DOWNLOAD_TEMPLATE['view']['nextprev'] = '
    <div class="float-left">
    	{DOWNLOAD_VIEW_PREV}
	</div>
	<div class="text-center ">
		{DOWNLOAD_BACK_TO_LIST}
	</div>
	<div class="float-right">
    	{DOWNLOAD_VIEW_NEXT}
	</div>
';

@Jimmi08
Copy link
Contributor Author

Jimmi08 commented Jan 7, 2020

Solved, I didn't run on this problem with latest BT4 themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement An improvement or new feature request type: question An ask about behavior that is not found documented anywhere
Projects
None yet
Development

No branches or pull requests

2 participants