Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact page without SEF URL #3566

Closed
Alex-e107nl opened this issue Nov 29, 2018 · 10 comments
Closed

Contact page without SEF URL #3566

Alex-e107nl opened this issue Nov 29, 2018 · 10 comments
Labels
type: enhancement An improvement or new feature request
Milestone

Comments

@Alex-e107nl
Copy link
Contributor

As i see it the only way to link to the contact page is with /contact.php right? There's no /contact defined somewhere or am i overlooking something?

Should be possible i think?

Alex

@Jimmi08
Copy link
Contributor

Jimmi08 commented Nov 29, 2018

If this is in core, there should be option to set this and in languages too

In custom plugin you can add e_url.php with

$config['contact'] = array(
			'alias'         => 'contactus',                         
			'regex'			=> '^{alias}\/$', 					 
			'sef'			=> '{alias}/', 						 
			'redirect'		=> '{e_BASE}contact.php',  
		);

image

image

image

@Alex-e107nl
Copy link
Contributor Author

Thx Jimmi08!! will try it!

@Moc Moc changed the title Contact page without SEO Contact page without SEF URL Nov 30, 2018
@Moc Moc added the type: question An ask about behavior that is not found documented anywhere label Nov 30, 2018
@Moc
Copy link
Member

Moc commented Nov 30, 2018

Would be a question for e107help rather than Github :) For the next time.
Let us know if you need further help though!

@Moc Moc closed this as completed Nov 30, 2018
@Moc Moc reopened this Nov 30, 2018
@Moc
Copy link
Member

Moc commented Nov 30, 2018

Actually, I think it might be missing from the core settings

@Alex-e107nl
Copy link
Contributor Author

Moc,
i've placed it here because i think it's not right that all the links can be SEO but not the contact page.. so it's a bug, forgotten or anything but it needs to be adressed..

@Moc
Copy link
Member

Moc commented Nov 30, 2018

Yeah you're right, my mistake, sorry 👍

@Moc Moc reopened this Nov 30, 2018
@Moc Moc added type: enhancement An improvement or new feature request and removed type: question An ask about behavior that is not found documented anywhere labels Nov 30, 2018
@Moc Moc added this to the e107 2.2.0 milestone Nov 30, 2018
@CaMer0n
Copy link
Member

CaMer0n commented Nov 30, 2018

@Alex-e107nl Please update then scan the plugin directories.

@Alex-e107nl
Copy link
Contributor Author

Tested, works perfectly thx Cameron!!

@Jimmi08
Copy link
Contributor

Jimmi08 commented Dec 3, 2018

@CaMer0n e_PAGE is changed, now it's index.php.
How to test that you are on contact page?

In theme.php I am not able to use e_URL_LEGACY either.

@Moc Moc reopened this Dec 4, 2018
@Moc Moc closed this as completed Dec 4, 2018
@Moc
Copy link
Member

Moc commented Dec 4, 2018

@CaMer0n Can you help @Jimmi08 with the constant when using SEF URLs? e.g. this issue and #3567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement An improvement or new feature request
Projects
None yet
Development

No branches or pull requests

4 participants