Language verify question

[yesszus]

Verify my language pack in localhost (windows 10 and xampp).
This is bug?

All errors: Non UTF-8 Characters Found

[tgtje]

No, it are no bugs. While changing (upload or transport) likely some white spaces were added just in front of starting php line eg. .... <php (points are blank) OR after closing tag.
In this case you ALSO may edit the file directly (use edit button), check IFF ..and save > that would work also. (however try to be sure if the lang pack (github) does not have it, because edit mode is system..)

[yesszus]

Perfect for the language pack and only for windows under this error.
Not find <php (points are blank) OR after closing tag.

[tgtje]

I suppose it is the Hungarian latest lang pack you are referring to.
Just downloaded it, installed and did run a check.
I too get 81 mistakes. Using the edit mode i do see that NOT all defines eg translations are read/displayed... Very strange....

@Moc can you please have a look into the Hungarian lang pack too ?

[Moc]

Two issues:

1. Issue reported by @tgtje that not all defines are read/displayed

2. The non-UTF8 error is caused by the ő and ó. Looking into it.

EDIT: I might be wrong about my conclusion on issue 2. Looking into it...

[Moc]

@CaMer0n Can you take a look at this please?

Test code:

<?php

function is_utf8($str) {
	/*
	* @see http://hsivonen.iki.fi/php-utf8/   validation.php
	*/
	if(strtolower('CHARSET') != "utf-8" || $str == "")
	{
		return TRUE;
	}

	return (preg_match('/^.{1}/us',$str,$ar) == 1);
}


$strings = array(
		"Főadminisztrátor",
		"Hői", 
		"Rendszerinformáció", 
		"Felhasználó", 
		"Regisztrált felhasználó"); 


echo "Test 1: mb_check_encoding() <br />"; 
foreach($strings as $string)
{
	if(mb_check_encoding($string, "UTF-8") == false)
	{
		echo "Error: ".$string." is NOT UTF-8 <br />"; 
	}
	else
	{
		echo "Success: ".$string." is UTF-8 <br />"; 
	}
}

echo "<br /><br />";
echo "Test 2: is_utf8() - e107 method <br />"; 

foreach($strings as $string)
{
	if(!is_utf8($string))
	{
		echo "Error: ".$string." is NOT UTF-8 <br />"; 
	}
	else
	{
		echo "Success: ".$string." is UTF-8 <br />"; 
	}
}

All test $strings pass as UTF-8 but but in e107_admin\lancheck.php on line 1310 $this->is_utf8($check[$k][$sk]) returns false.....
No idea where the issue is....

[Moc]

@SimSync Maybe you have an idea on this one?

[SimSync]

@CaMer0n @Moc On line 1926 (lancheck.php), the string from the language file get's malformed for some reason.
I think it's because of the regex used to extract the define values.

Edit: I think i found the issue... There was a missing unicode flag in the regex to match the defines.
Will check it first with the current hungarian and russian language files.

Edit: It is working for me. PR submitted

[yesszus]

Solved problem!
Great job @SimSync !

[tgtje]

Just to confirm it does work here too 👍 (all (81) errors are gone.. (Hungarian)

[CaMer0n]

Thank you @SimSync @Moc
We should add that test code into e107-tests

[SimSync]

@CaMer0n Could you provide the test class for lancheck.php? I will add than the tests

[CaMer0n]

@SimSync Done!