Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Upgrading from 1.x to 2.x #4

Closed
CaMer0n opened this issue Nov 28, 2012 · 9 comments
Closed

Test Upgrading from 1.x to 2.x #4

CaMer0n opened this issue Nov 28, 2012 · 9 comments
Assignees
Labels
status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing.
Milestone

Comments

@CaMer0n
Copy link
Member

CaMer0n commented Nov 28, 2012

Should work, more testing needed, not crucial for alpha

@ghost ghost assigned Moc Nov 28, 2012
CaMer0n added a commit that referenced this issue Dec 7, 2012
CaMer0n added a commit that referenced this issue Dec 7, 2012
@Moc
Copy link
Member

Moc commented Dec 7, 2012

Testing is in progress, thanks Cameron 👍

@STR82U
Copy link
Contributor

STR82U commented Jan 12, 2013

Got through to the dbase updates/upgrades but ended up with the "Forum" update failing due to:
"Fatal error: Call to undefined function update_forum_08() in /home/picture/public_html/e107_plugins/forum/forum_update.php on line 1073"

Custom theme and coding made it hard to tell but the core theme looked ok, gallery functioned, plugins seemed to be fine but not many installed. Going to make more detailed list later after the next test.

Site tested by swapping out public_html files and moving custom folders over.
Going to test this again after a backup can merge the files and see how much easier it is.

SUGGESTION: When there's a dbase update with (Must be run first) - Put that at the top so people see it, maybe draw more attention to to that particular update v1 to v2.

@STR82U
Copy link
Contributor

STR82U commented Jan 12, 2013

Second upgrade test was prepared by merging a backup copy of public_html with the current V2 GitHub build.

Had to uninstall cl_widgets plugin BEFORE swapping the original public_html for the V2 folder. An error I forgot to copy. Trying to reinstall it stopped this run of testing.

Got through to the dbase updates/upgrades.
System told me which folders to delete from the plugins folder.
Ended up with the "Forum" update failing due to: "Fatal error: Call to undefined function update_forum_08() in /home/picture/public_html/e107_plugins/forum/forum_update.php on line 1073"

While the cl_widgets plugin was uninstalled the front end looked normal using the core theme; contact page, forum, front page, gallery, a few others but no changes in admin (changed theme before changing to V2_merged folder.

Will make another go of it later and leave the plugin uninstalled.

@STR82U
Copy link
Contributor

STR82U commented Jan 12, 2013

ROUND 3: Testing today with a simple V1.0.2 that uses "Kubrick" as the site theme - no fancy plugins.
The upgrade was prepared by merging a backup copy of public_html with the current V2 GitHub build.

Clicked to update dbase > Update from 1.x to 2.0 (Must be run first) > Successful: asked to remove old folders:
Before continuing, please manually delete the following outdated folders from your system:
/e107_plugins/compliance_menu
/e107_plugins/counter_menu
/e107_plugins/other_news_menu
/e107_plugins/powered_by_menu
/e107_plugins/sitebutton_menu
/e107_plugins/userlanguage_menu
/e107_plugins/usertheme_menu

2nd update from: "Update from 1.x to 2.0 (Must be run first) > Success
Update: Add additional/missing core settings > Success
Update: Calendar Plugin > Success (added a new tab/sitelink for calendar that was bad - http://www example com/{e_UPLOAD}e107_plugins/calendar_menu/calendar.php )
Update: Statistic Logging > Success (Adding Link: Visits with url [{e_PLUGIN}log/stats.php?1] and perm everyone) - added link that was bad - http://www example com/{e_UPLOAD}e107_plugins/log/stats.php?1

At this point the PUBLIC view of the site is normal except for the demo news item getting added to the front page may have reset the "Front Page" settings. Changed "Front Page" settings to "Welcome Message" successfully.
At this point the ADMIN view of the front end is missing the lower half of pages > investigating >> this error may have been caused by the MENU ITEM private_msg (PM) with visibility set to "Admin" - plugin was installed and still is. Removing then reading the menu item causes the error to reappear to admins in the front end.

NOTES:

3 Times the FF browser (once with Chrome) cache was cleared and the Admin logged back in, the dbase update notice reappears: "There is a database update available, please click button to install ..." and performed Update from V1 to V2. The 4th cache clear and admin login showed no updates available. Logging in to admin with other browsers confirms this.
The above notice came back one more time in FF after cleaning the dbase manually using phpMyAdmin (failed logins and spam news items) - all the repeated dbase updates were only for "Update from 1.x to 2.0 (Must be run first)" > Success every time.

Error Log Had This To Say (dots removed from URLs to prevent links):
[Sat Jan 12 08:23:05 2013] [error] [client 168.6.225.225] File does not exist: /home/example/public_html/e107_images/bbcode/table.png, referer: http://www example com/e107_admin/cpage.php?mode=menu&action=edit&id=5
[Sat Jan 12 08:21:24 2013] [error] [client 168.6.225.225] File does not exist: /home/example/public_html/e107_web/js/bootstrap/css/images, referer: http://www example com/e107_admin/cpage.php?mode=menu&action=edit&id=5
[Sat Jan 12 08:21:24 2013] [error] [client 168.6.225.225] File does not exist: /home/example/public_html/e107_images/bbcode/table.png, referer: http://www example com/e107_admin/cpage.php?mode=menu&action=edit&id=5

After ALL upgrades and fresh installs (not just this one), OPERA browser kicks out this JS error:
"Uncaught exception: ReferenceError: Undefined variable: SyncWithServerTime"
(there was not much more detail than that, I'll create an Issue later if it doesn't come out first).

Happy with this upgrade - going to leave it in place.

@STR82U
Copy link
Contributor

STR82U commented Jan 13, 2013

Round 4: Tested Jan. Saturday 12 2013 - Upgraded a V1.0.2 to V2 after minor preference and plugin changes before the upgrade.

No Issues.

@STR82U
Copy link
Contributor

STR82U commented Jan 13, 2013

Round 5: Tested on Jan. Sunday 13 2013 - Upgraded a 0.7.24 to V1.0.2 to V2 - SITE HAS CUSTOM HTACCESS
original site install date: Sunday 18 June 2006 - 14:34:54

The upgrade from 0.7.24 to V1.0.2 left the admin area with a non-default admin theme, changed to Jayya and then Core with acceptable results. Public side of site seemed unaffected.

The upgrade from V1.0.2 to V2 was in line with current expectations; updated dbase one, removed deprecated folders, updated dbase 2nd time, updated core settings, then repeated requests from system to repeat "Update from 1.x to 2.0 (Must be run first)".

AFTER ALL UPGRADES:

Banner Plugin - isn't a plugin on the live site this upgrade was done from and had to be installed. No functionality returned to frontend and the Update Banner page doesn't display anything from the /e107_images/banner/ directory ("Banner Image" button doesn't open the dropdown selections) - personally this can be overcome with shortcode BUT may have been avoided with more time spent after upgrading to V1.0.2 - this is acceptable to me. Other conditions that apply are that this theme replied on custom hacks over the years.

Front end custom htaccess works except one type of conflicting rewrite from a deprecated plugin goes 404 (FURL Still Installed but htaccess works for 95% of pages in this small site). Text editor "find and replace" can fix that.

Other plugins installed in original site include: Content Management, The e107Helper Project, ADD This, e107_mobile, Page Creator (For Noobs) and Wrap.

NOTE: This was a successful test - nothing lost due to core or default files.

@CaMer0n
Copy link
Member Author

CaMer0n commented Jan 18, 2013

If there are repeated requests to "update from 1.x to 2.0" - please enable debugging and take note of what is causing the request to be triggered. Ideally, the update should only need to be run once.

@STR82U
Copy link
Contributor

STR82U commented Jan 18, 2013

"please enable debugging and take note of what is causing the request to be triggered" - Understood.

@CaMer0n
Copy link
Member Author

CaMer0n commented May 16, 2013

Closing this for alpha1. We can open another for alpha2.

@CaMer0n CaMer0n closed this as completed May 16, 2013
@CaMer0n CaMer0n modified the milestones: v2.0 beta 2, v2.0 beta 1 Feb 3, 2015
Deltik pushed a commit that referenced this issue Nov 27, 2019
Deltik added a commit that referenced this issue Dec 27, 2019
Error message from Code Climate:

> Exception: The given file "/code/e107_tests/lib/ci/salt/pillars/config-local.sls" does not exist. in /usr/src/app/vendor/pdepend/pdepend/src/main/php/PDepend/Engine.php
> #0 /usr/src/app/vendor/phpmd/phpmd/src/main/php/PHPMD/ParserFactory.php(129): PDepend\Engine->addFile('/code/e107_test...')
> #1 /usr/src/app/vendor/phpmd/phpmd/src/main/php/PHPMD/ParserFactory.php(109): PHPMD\ParserFactory->initInput(Object(PDepend\Engine), Object(PHPMD\PHPMD))
> #2 /usr/src/app/vendor/phpmd/phpmd/src/main/php/PHPMD/ParserFactory.php(76): PHPMD\ParserFactory->init(Object(PDepend\Engine), Object(PHPMD\PHPMD))
> #3 /usr/src/app/vendor/phpmd/phpmd/src/main/php/PHPMD/PHPMD.php(215): PHPMD\ParserFactory->create(Object(PHPMD\PHPMD))
> #4 /usr/src/app/Runner.php(116): PHPMD\PHPMD->processFiles('/code/e107_test...', 'cleancode,unuse...', Array, Object(PHPMD\RuleSetFactory))
> #5 /usr/src/app/vendor/barracudanetworks/forkdaemon-php/fork_daemon.php(1852): CodeClimate\PHPMD\Runner->run(Array)
> #6 /usr/src/app/vendor/barracudanetworks/forkdaemon-php/fork_daemon.php(1772): fork_daemon->invoke_callback(Array, Array, false)
> #7 /usr/src/app/vendor/barracudanetworks/forkdaemon-php/fork_daemon.php(1673): fork_daemon->fork_work_unit(Array, '', -1)
> #8 /usr/src/app/vendor/barracudanetworks/forkdaemon-php/fork_daemon.php(1445): fork_daemon->process_work_unit(-1)
> #9 /usr/src/app/Runner.php(31): fork_daemon->process_work(false)
> #10 /usr/src/app/engine.php(35): CodeClimate\PHPMD\Runner->queueDirectory('/code')
> #11 {main}
Deltik added a commit that referenced this issue Mar 7, 2020
---------
1) lancheckTest: Is_utf8
 Test  tests/unit/lancheckTest.php:testIs_utf8

  [PHPUnit_Framework_Exception] Constant LAN_SETSAVED already defined

#1  Codeception\Subscriber\ErrorHandler->errorHandler
#2  /__w/e107/e107/e107_languages/English/admin/lan_admin.php:262
#3  /__w/e107/e107/e107_handlers/e107_class.php:3156
#4  /__w/e107/e107/e107_handlers/e107_class.php:3182
#5  /__w/e107/e107/e107_admin/lancheck.php:18
#6  /__w/e107/e107/e107_tests/tests/unit/lancheckTest.php:18
#7  {closure}
Kojack-59 referenced this issue Mar 29, 2020
Bugs fixed:

* Security failure status is now prioritized in
  file_inspector::getStatusForValidationCode()
* File Inspector list view now supports filters
Deltik added a commit to Deltik/e107 that referenced this issue Nov 28, 2020
```
[Sat Nov 28 07:42:08.146694 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: PHP Fatal error:  Uncaught Error: Non-static method e_date::convert_date() cannot be called statically in ~/public_html/e107_handlers/bbcode_handler.php(390) : eval()'d code:6
[Sat Nov 28 07:42:08.146832 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: Stack trace:
[Sat Nov 28 07:42:08.146841 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: #0 ~/public_html/e107_handlers/bbcode_handler.php(390): eval()
[Sat Nov 28 07:42:08.146848 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#1 ~/public_html/e107_handlers/bbcode_handler.php(202): e_bbcode->proc_bbcode()
[Sat Nov 28 07:42:08.146853 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#2 ~/public_html/e107_handlers/e_parse_class.php(1919): e_bbcode->parseBBCodes()
[Sat Nov 28 07:42:08.146859 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#3 ~/public_html/e107_core/shortcodes/batch/comment_shortcodes.php(350): e_parse->toHTML()
[Sat Nov 28 07:42:08.146882 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#4 ~/public_html/e107_handlers/shortcode_handler.php(1119): comment_shortcodes->sc_comment()
[Sat Nov 28 07:42:08.146888 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#5 [internal function]: e_parse_shortcode->doCode()
[Sat Nov 28 07:42:08.146908 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#6 ~/public_html/e107_handlers/shortcode_handler.php(986): preg_replace_callback()
[Sat Nov 28 07:42:08.146914 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#7 ~/public_html/e107_handlers/e_parse_class.php(883): e_parse_shortcode->parseCodes()
[Sat Nov 28 07:42:08.146920 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#8 ~/public_html/e107_handlers/comment_class.php(534): e_parse->parseTemplate()
[Sat Nov 28 07:42:08.146926 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#9 ~/public_html/e107_handlers/comment_class.php(1301): comment->render_comment()
[Sat Nov 28 07:42:08.146931 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#10 ~/public_html/e107_handlers/comment_class.php(1125): comment->getComments()
[Sat Nov 28 07:42:08.146938 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#11 ~/public_html/e107_plugins/news/news.php(1299): comment->compose_comment()
[Sat Nov 28 07:42:08.146943 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#12 ~/public_html/e107_plugins/news/news.php(236): news_front->renderComments()
[Sat Nov 28 07:42:08.146950 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#13 ~/public_html/e107_plugins/news/news.php(1895): news_front->render()
[Sat Nov 28 07:42:08.146955 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#14 ~/public_html/news.php(23): require_once('...')
[Sat Nov 28 07:42:08.146961 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#15 ~/public_html/index.php(103): include('...')
[Sat Nov 28 07:42:08.146967 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#16 {main}
[Sat Nov 28 07:42:08.146972 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr:   thrown in ~/public_html/e107_handlers/bbcode_handler.php(390) : eval()'d code on line 6
```
Deltik added a commit to Deltik/e107 that referenced this issue Nov 30, 2020
```
[Sat Nov 28 07:42:08.146694 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: PHP Fatal error:  Uncaught Error: Non-static method e_date::convert_date() cannot be called statically in ~/public_html/e107_handlers/bbcode_handler.php(390) : eval()'d code:6
[Sat Nov 28 07:42:08.146832 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: Stack trace:
[Sat Nov 28 07:42:08.146841 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: #0 ~/public_html/e107_handlers/bbcode_handler.php(390): eval()
[Sat Nov 28 07:42:08.146848 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#1 ~/public_html/e107_handlers/bbcode_handler.php(202): e_bbcode->proc_bbcode()
[Sat Nov 28 07:42:08.146853 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#2 ~/public_html/e107_handlers/e_parse_class.php(1919): e_bbcode->parseBBCodes()
[Sat Nov 28 07:42:08.146859 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#3 ~/public_html/e107_core/shortcodes/batch/comment_shortcodes.php(350): e_parse->toHTML()
[Sat Nov 28 07:42:08.146882 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#4 ~/public_html/e107_handlers/shortcode_handler.php(1119): comment_shortcodes->sc_comment()
[Sat Nov 28 07:42:08.146888 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#5 [internal function]: e_parse_shortcode->doCode()
[Sat Nov 28 07:42:08.146908 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#6 ~/public_html/e107_handlers/shortcode_handler.php(986): preg_replace_callback()
[Sat Nov 28 07:42:08.146914 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#7 ~/public_html/e107_handlers/e_parse_class.php(883): e_parse_shortcode->parseCodes()
[Sat Nov 28 07:42:08.146920 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#8 ~/public_html/e107_handlers/comment_class.php(534): e_parse->parseTemplate()
[Sat Nov 28 07:42:08.146926 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#9 ~/public_html/e107_handlers/comment_class.php(1301): comment->render_comment()
[Sat Nov 28 07:42:08.146931 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#10 ~/public_html/e107_handlers/comment_class.php(1125): comment->getComments()
[Sat Nov 28 07:42:08.146938 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#11 ~/public_html/e107_plugins/news/news.php(1299): comment->compose_comment()
[Sat Nov 28 07:42:08.146943 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#12 ~/public_html/e107_plugins/news/news.php(236): news_front->renderComments()
[Sat Nov 28 07:42:08.146950 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#13 ~/public_html/e107_plugins/news/news.php(1895): news_front->render()
[Sat Nov 28 07:42:08.146955 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#14 ~/public_html/news.php(23): require_once('...')
[Sat Nov 28 07:42:08.146961 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#15 ~/public_html/index.php(103): include('...')
[Sat Nov 28 07:42:08.146967 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr: e107inc#16 {main}
[Sat Nov 28 07:42:08.146972 2020] [fcgid:warn] [pid 224726:tid 140236713551616] [client xxx.xxx.xxx.xxx:0] mod_fcgid: stderr:   thrown in ~/public_html/e107_handlers/bbcode_handler.php(390) : eval()'d code on line 6
```
Deltik added a commit that referenced this issue Dec 17, 2020
Fixes this fatal error:

```
PHP Fatal error:  Uncaught Error: Undefined constant "ADMIN_AREA" in ~/public_html/e107_handlers/form_handler.php:6505, referer: https://example.net/e107_admin/users.php
Stack trace:, referer: https://example.net/e107_admin/users.php
#0 ~/public_html/e107_handlers/admin_ui.php(7095): e_form->renderListForm(), referer: https://example.net/e107_admin/users.php
#1 ~/public_html/e107_handlers/admin_ui.php(6152): e_admin_form_ui->getList(), referer: https://example.net/e107_admin/users.php
#2 ~/public_html/e107_handlers/admin_ui.php(2275): e_admin_ui->ListAjaxPage(), referer: https://example.net/e107_admin/users.php
#3 ~/public_html/e107_handlers/admin_ui.php(1335): e_admin_controller->dispatchPage(), referer: https://example.net/e107_admin/users.php
#4 ~/public_html/e107_admin/users.php(3005): e_admin_dispatcher->runPage(), referer: https://example.net/e107_admin/users.php
#5 {main}, referer: https://example.net/e107_admin/users.php
  thrown in ~/public_html/e107_handlers/form_handler.php on line 6505, referer: https://example.net/e107_admin/users.php
```
Deltik added a commit that referenced this issue Dec 31, 2020
```
PHP Fatal error:  Uncaught TypeError: Unsupported operand types: array & int in ~/public_html/e107_admin/fileinspector.php:1266
Stack trace:
#0 ~/public_html/e107_admin/fileinspector.php(717): file_inspector->getOldVersionOfPath()
#1 ~/public_html/e107_admin/fileinspector.php(677): file_inspector->generateDirectoryHtml()
#2 ~/public_html/e107_admin/fileinspector.php(961): file_inspector->generateScanResultsHtml()
#3 ~/public_html/e107_admin/fileinspector.php(156): file_inspector->scan_results()
#4 ~/public_html/e107_handlers/admin_ui.php(1076): fileinspector_admin->init()
#5 ~/public_html/e107_admin/fileinspector.php(249): e_admin_dispatcher->__construct()
#6 {main}
  thrown in ~/public_html/e107_admin/fileinspector.php on line 1266
```
Deltik added a commit to Deltik/e107 that referenced this issue Mar 31, 2021
---------
1) e_navigationTest: Admin links plugins
 Test  tests/unit/e_navigationTest.php:testAdminLinksPlugins

Error: ;1m  [Error] Undefined constant "E_16_PLUGMANAGER"

e107inc#1  /__w/e107/e107/e107_handlers/sitelinks_class.php:882
e107inc#2  /__w/e107/e107/e107_tests/tests/unit/e_navigationTest.php:528

---------
2) e_navigationTest: Admin links legacy
 Test  tests/unit/e_navigationTest.php:testAdminLinksLegacy

Error: ;1m  [Error] Undefined constant "E_32_MAIN"

e107inc#1  /__w/e107/e107/e107_handlers/sitelinks_class.php:735
e107inc#2  /__w/e107/e107/e107_handlers/sitelinks_class.php:887
e107inc#3  /__w/e107/e107/e107_tests/tests/unit/e_navigationTest.php:374

---------
3) e_formTest: Render value
 Test  tests/unit/e_formTest.php:testRenderValue

Error: ;1m  [Error] Undefined constant "ADMIN_TRUE_ICON"

e107inc#1  /__w/e107/e107/e107_tests/tests/unit/e_formTest.php:943

---------
4) scriptsTest: Admin scripts
 Test  tests/unit/scriptsTest.php:testAdminScripts

Error: ;1m  [Error] Undefined constant "E_32_MAIN"

e107inc#1  /__w/e107/e107/e107_handlers/sitelinks_class.php:735
e107inc#2  /__w/e107/e107/e107_handlers/sitelinks_class.php:887
e107inc#3  /__w/e107/e107/e107_admin/includes/infopanel.php:110
e107inc#4  /__w/e107/e107/e107_admin/includes/flexpanel.php:66
e107inc#5  /__w/e107/e107/e107_admin/admin.php:63
e107inc#6  /__w/e107/e107/e107_tests/tests/unit/scriptsTest.php:140
e107inc#7  /__w/e107/e107/e107_tests/tests/unit/scriptsTest.php:27

---------
5) e_formTest: Render value inline
 Test  tests/unit/e_formTest.php:testRenderValueInline

Error: ;1m  [Error] Undefined constant "ADMIN_FALSE_ICON"

e107inc#1  /__w/e107/e107/e107_handlers/form_handler.php:5829
e107inc#2  /__w/e107/e107/e107_tests/tests/unit/e_formTest.php:1029

---------
6) e_navigationTest: Admin links sub
 Test  tests/unit/e_navigationTest.php:testAdminLinksSub

Error: ;1m  [Error] Undefined constant "E_32_MAIN"

e107inc#1  /__w/e107/e107/e107_handlers/sitelinks_class.php:735
e107inc#2  /__w/e107/e107/e107_handlers/sitelinks_class.php:887
e107inc#3  /__w/e107/e107/e107_tests/tests/unit/e_navigationTest.php:418

---------
7) e_parse_shortcodeTest: Admin shortcodes
 Test  tests/unit/e_parse_shortcodeTest.php:testAdminShortcodes

Error: ;1m  [Error] Undefined constant "E_16_NEWS"

e107inc#1  /__w/e107/e107/e107_core/shortcodes/batch/admin_shortcodes.php:518
e107inc#2  /__w/e107/e107/e107_core/shortcodes/batch/admin_shortcodes.php:602
e107inc#3  /__w/e107/e107/e107_handlers/shortcode_handler.php:1130
e107inc#4  e_parse_shortcode->doCode
e107inc#5  /__w/e107/e107/e107_handlers/shortcode_handler.php:996
e107inc#6  /__w/e107/e107/e107_handlers/e_parse_class.php:823
e107inc#7  /__w/e107/e107/e107_tests/tests/unit/e_parse_shortcodeTest.php:1588
e107inc#8  /__w/e107/e107/e107_tests/tests/unit/e_parse_shortcodeTest.php:220

---------
8) scriptsTest: Admin includes
 Test  tests/unit/scriptsTest.php:testAdminIncludes

Error: ;1m  [Error] Undefined constant "E_32_MAIN"

e107inc#1  /__w/e107/e107/e107_handlers/sitelinks_class.php:735
e107inc#2  /__w/e107/e107/e107_handlers/sitelinks_class.php:887
e107inc#3  /__w/e107/e107/e107_admin/includes/categories.php:22
e107inc#4  /__w/e107/e107/e107_tests/tests/unit/scriptsTest.php:140
e107inc#5  /__w/e107/e107/e107_tests/tests/unit/scriptsTest.php:36

--

There was 1 failure:

---------
1) e107Test: Load admin icons
 Test  tests/unit/e107Test.php:testLoadAdminIcons
E_16_FACEBOOK is missing from admin_icons_template
e107inc#1  /__w/e107/e107/e107_tests/tests/unit/e107Test.php:1054
Deltik added a commit to Deltik/e107 that referenced this issue Mar 31, 2021
---------
1) e_navigationTest: Admin links plugins
 Test  tests/unit/e_navigationTest.php:testAdminLinksPlugins

Error: ;1m  [Error] Undefined constant "E_16_PLUGMANAGER"

e107inc#1  /__w/e107/e107/e107_handlers/sitelinks_class.php:882
e107inc#2  /__w/e107/e107/e107_tests/tests/unit/e_navigationTest.php:528

---------
2) e_navigationTest: Admin links legacy
 Test  tests/unit/e_navigationTest.php:testAdminLinksLegacy

Error: ;1m  [Error] Undefined constant "E_32_MAIN"

e107inc#1  /__w/e107/e107/e107_handlers/sitelinks_class.php:735
e107inc#2  /__w/e107/e107/e107_handlers/sitelinks_class.php:887
e107inc#3  /__w/e107/e107/e107_tests/tests/unit/e_navigationTest.php:374

---------
3) e_formTest: Render value
 Test  tests/unit/e_formTest.php:testRenderValue

Error: ;1m  [Error] Undefined constant "ADMIN_TRUE_ICON"

e107inc#1  /__w/e107/e107/e107_tests/tests/unit/e_formTest.php:943

---------
4) scriptsTest: Admin scripts
 Test  tests/unit/scriptsTest.php:testAdminScripts

Error: ;1m  [Error] Undefined constant "E_32_MAIN"

e107inc#1  /__w/e107/e107/e107_handlers/sitelinks_class.php:735
e107inc#2  /__w/e107/e107/e107_handlers/sitelinks_class.php:887
e107inc#3  /__w/e107/e107/e107_admin/includes/infopanel.php:110
e107inc#4  /__w/e107/e107/e107_admin/includes/flexpanel.php:66
e107inc#5  /__w/e107/e107/e107_admin/admin.php:63
e107inc#6  /__w/e107/e107/e107_tests/tests/unit/scriptsTest.php:140
e107inc#7  /__w/e107/e107/e107_tests/tests/unit/scriptsTest.php:27

---------
5) e_formTest: Render value inline
 Test  tests/unit/e_formTest.php:testRenderValueInline

Error: ;1m  [Error] Undefined constant "ADMIN_FALSE_ICON"

e107inc#1  /__w/e107/e107/e107_handlers/form_handler.php:5829
e107inc#2  /__w/e107/e107/e107_tests/tests/unit/e_formTest.php:1029

---------
6) e_navigationTest: Admin links sub
 Test  tests/unit/e_navigationTest.php:testAdminLinksSub

Error: ;1m  [Error] Undefined constant "E_32_MAIN"

e107inc#1  /__w/e107/e107/e107_handlers/sitelinks_class.php:735
e107inc#2  /__w/e107/e107/e107_handlers/sitelinks_class.php:887
e107inc#3  /__w/e107/e107/e107_tests/tests/unit/e_navigationTest.php:418

---------
7) e_parse_shortcodeTest: Admin shortcodes
 Test  tests/unit/e_parse_shortcodeTest.php:testAdminShortcodes

Error: ;1m  [Error] Undefined constant "E_16_NEWS"

e107inc#1  /__w/e107/e107/e107_core/shortcodes/batch/admin_shortcodes.php:518
e107inc#2  /__w/e107/e107/e107_core/shortcodes/batch/admin_shortcodes.php:602
e107inc#3  /__w/e107/e107/e107_handlers/shortcode_handler.php:1130
e107inc#4  e_parse_shortcode->doCode
e107inc#5  /__w/e107/e107/e107_handlers/shortcode_handler.php:996
e107inc#6  /__w/e107/e107/e107_handlers/e_parse_class.php:823
e107inc#7  /__w/e107/e107/e107_tests/tests/unit/e_parse_shortcodeTest.php:1588
e107inc#8  /__w/e107/e107/e107_tests/tests/unit/e_parse_shortcodeTest.php:220

---------
8) scriptsTest: Admin includes
 Test  tests/unit/scriptsTest.php:testAdminIncludes

Error: ;1m  [Error] Undefined constant "E_32_MAIN"

e107inc#1  /__w/e107/e107/e107_handlers/sitelinks_class.php:735
e107inc#2  /__w/e107/e107/e107_handlers/sitelinks_class.php:887
e107inc#3  /__w/e107/e107/e107_admin/includes/categories.php:22
e107inc#4  /__w/e107/e107/e107_tests/tests/unit/scriptsTest.php:140
e107inc#5  /__w/e107/e107/e107_tests/tests/unit/scriptsTest.php:36

--

There was 1 failure:

---------
1) e107Test: Load admin icons
 Test  tests/unit/e107Test.php:testLoadAdminIcons
E_16_FACEBOOK is missing from admin_icons_template
e107inc#1  /__w/e107/e107/e107_tests/tests/unit/e107Test.php:1054
Deltik added a commit to Deltik/e107 that referenced this issue Mar 31, 2021
---------
1) e_navigationTest: Admin links plugins
 Test  tests/unit/e_navigationTest.php:testAdminLinksPlugins

Error: ;1m  [Error] Undefined constant "E_16_PLUGMANAGER"

e107inc#1  /__w/e107/e107/e107_handlers/sitelinks_class.php:882
e107inc#2  /__w/e107/e107/e107_tests/tests/unit/e_navigationTest.php:528

---------
2) e_navigationTest: Admin links legacy
 Test  tests/unit/e_navigationTest.php:testAdminLinksLegacy

Error: ;1m  [Error] Undefined constant "E_32_MAIN"

e107inc#1  /__w/e107/e107/e107_handlers/sitelinks_class.php:735
e107inc#2  /__w/e107/e107/e107_handlers/sitelinks_class.php:887
e107inc#3  /__w/e107/e107/e107_tests/tests/unit/e_navigationTest.php:374

---------
3) e_formTest: Render value
 Test  tests/unit/e_formTest.php:testRenderValue

Error: ;1m  [Error] Undefined constant "ADMIN_TRUE_ICON"

e107inc#1  /__w/e107/e107/e107_tests/tests/unit/e_formTest.php:943

---------
4) scriptsTest: Admin scripts
 Test  tests/unit/scriptsTest.php:testAdminScripts

Error: ;1m  [Error] Undefined constant "E_32_MAIN"

e107inc#1  /__w/e107/e107/e107_handlers/sitelinks_class.php:735
e107inc#2  /__w/e107/e107/e107_handlers/sitelinks_class.php:887
e107inc#3  /__w/e107/e107/e107_admin/includes/infopanel.php:110
e107inc#4  /__w/e107/e107/e107_admin/includes/flexpanel.php:66
e107inc#5  /__w/e107/e107/e107_admin/admin.php:63
e107inc#6  /__w/e107/e107/e107_tests/tests/unit/scriptsTest.php:140
e107inc#7  /__w/e107/e107/e107_tests/tests/unit/scriptsTest.php:27

---------
5) e_formTest: Render value inline
 Test  tests/unit/e_formTest.php:testRenderValueInline

Error: ;1m  [Error] Undefined constant "ADMIN_FALSE_ICON"

e107inc#1  /__w/e107/e107/e107_handlers/form_handler.php:5829
e107inc#2  /__w/e107/e107/e107_tests/tests/unit/e_formTest.php:1029

---------
6) e_navigationTest: Admin links sub
 Test  tests/unit/e_navigationTest.php:testAdminLinksSub

Error: ;1m  [Error] Undefined constant "E_32_MAIN"

e107inc#1  /__w/e107/e107/e107_handlers/sitelinks_class.php:735
e107inc#2  /__w/e107/e107/e107_handlers/sitelinks_class.php:887
e107inc#3  /__w/e107/e107/e107_tests/tests/unit/e_navigationTest.php:418

---------
7) e_parse_shortcodeTest: Admin shortcodes
 Test  tests/unit/e_parse_shortcodeTest.php:testAdminShortcodes

Error: ;1m  [Error] Undefined constant "E_16_NEWS"

e107inc#1  /__w/e107/e107/e107_core/shortcodes/batch/admin_shortcodes.php:518
e107inc#2  /__w/e107/e107/e107_core/shortcodes/batch/admin_shortcodes.php:602
e107inc#3  /__w/e107/e107/e107_handlers/shortcode_handler.php:1130
e107inc#4  e_parse_shortcode->doCode
e107inc#5  /__w/e107/e107/e107_handlers/shortcode_handler.php:996
e107inc#6  /__w/e107/e107/e107_handlers/e_parse_class.php:823
e107inc#7  /__w/e107/e107/e107_tests/tests/unit/e_parse_shortcodeTest.php:1588
e107inc#8  /__w/e107/e107/e107_tests/tests/unit/e_parse_shortcodeTest.php:220

---------
8) scriptsTest: Admin includes
 Test  tests/unit/scriptsTest.php:testAdminIncludes

Error: ;1m  [Error] Undefined constant "E_32_MAIN"

e107inc#1  /__w/e107/e107/e107_handlers/sitelinks_class.php:735
e107inc#2  /__w/e107/e107/e107_handlers/sitelinks_class.php:887
e107inc#3  /__w/e107/e107/e107_admin/includes/categories.php:22
e107inc#4  /__w/e107/e107/e107_tests/tests/unit/scriptsTest.php:140
e107inc#5  /__w/e107/e107/e107_tests/tests/unit/scriptsTest.php:36

--

There was 1 failure:

---------
1) e107Test: Load admin icons
 Test  tests/unit/e107Test.php:testLoadAdminIcons
E_16_FACEBOOK is missing from admin_icons_template
e107inc#1  /__w/e107/e107/e107_tests/tests/unit/e107Test.php:1054
Deltik added a commit to Deltik/e107 that referenced this issue Apr 13, 2021
---------
1) e_navigationTest: Admin links plugins
 Test  tests/unit/e_navigationTest.php:testAdminLinksPlugins

Error: ;1m  [Error] Undefined constant "E_16_PLUGMANAGER"

e107inc#1  /__w/e107/e107/e107_handlers/sitelinks_class.php:882
e107inc#2  /__w/e107/e107/e107_tests/tests/unit/e_navigationTest.php:528

---------
2) e_navigationTest: Admin links legacy
 Test  tests/unit/e_navigationTest.php:testAdminLinksLegacy

Error: ;1m  [Error] Undefined constant "E_32_MAIN"

e107inc#1  /__w/e107/e107/e107_handlers/sitelinks_class.php:735
e107inc#2  /__w/e107/e107/e107_handlers/sitelinks_class.php:887
e107inc#3  /__w/e107/e107/e107_tests/tests/unit/e_navigationTest.php:374

---------
3) e_formTest: Render value
 Test  tests/unit/e_formTest.php:testRenderValue

Error: ;1m  [Error] Undefined constant "ADMIN_TRUE_ICON"

e107inc#1  /__w/e107/e107/e107_tests/tests/unit/e_formTest.php:943

---------
4) scriptsTest: Admin scripts
 Test  tests/unit/scriptsTest.php:testAdminScripts

Error: ;1m  [Error] Undefined constant "E_32_MAIN"

e107inc#1  /__w/e107/e107/e107_handlers/sitelinks_class.php:735
e107inc#2  /__w/e107/e107/e107_handlers/sitelinks_class.php:887
e107inc#3  /__w/e107/e107/e107_admin/includes/infopanel.php:110
e107inc#4  /__w/e107/e107/e107_admin/includes/flexpanel.php:66
e107inc#5  /__w/e107/e107/e107_admin/admin.php:63
e107inc#6  /__w/e107/e107/e107_tests/tests/unit/scriptsTest.php:140
e107inc#7  /__w/e107/e107/e107_tests/tests/unit/scriptsTest.php:27

---------
5) e_formTest: Render value inline
 Test  tests/unit/e_formTest.php:testRenderValueInline

Error: ;1m  [Error] Undefined constant "ADMIN_FALSE_ICON"

e107inc#1  /__w/e107/e107/e107_handlers/form_handler.php:5829
e107inc#2  /__w/e107/e107/e107_tests/tests/unit/e_formTest.php:1029

---------
6) e_navigationTest: Admin links sub
 Test  tests/unit/e_navigationTest.php:testAdminLinksSub

Error: ;1m  [Error] Undefined constant "E_32_MAIN"

e107inc#1  /__w/e107/e107/e107_handlers/sitelinks_class.php:735
e107inc#2  /__w/e107/e107/e107_handlers/sitelinks_class.php:887
e107inc#3  /__w/e107/e107/e107_tests/tests/unit/e_navigationTest.php:418

---------
7) e_parse_shortcodeTest: Admin shortcodes
 Test  tests/unit/e_parse_shortcodeTest.php:testAdminShortcodes

Error: ;1m  [Error] Undefined constant "E_16_NEWS"

e107inc#1  /__w/e107/e107/e107_core/shortcodes/batch/admin_shortcodes.php:518
e107inc#2  /__w/e107/e107/e107_core/shortcodes/batch/admin_shortcodes.php:602
e107inc#3  /__w/e107/e107/e107_handlers/shortcode_handler.php:1130
e107inc#4  e_parse_shortcode->doCode
e107inc#5  /__w/e107/e107/e107_handlers/shortcode_handler.php:996
e107inc#6  /__w/e107/e107/e107_handlers/e_parse_class.php:823
e107inc#7  /__w/e107/e107/e107_tests/tests/unit/e_parse_shortcodeTest.php:1588
e107inc#8  /__w/e107/e107/e107_tests/tests/unit/e_parse_shortcodeTest.php:220

---------
8) scriptsTest: Admin includes
 Test  tests/unit/scriptsTest.php:testAdminIncludes

Error: ;1m  [Error] Undefined constant "E_32_MAIN"

e107inc#1  /__w/e107/e107/e107_handlers/sitelinks_class.php:735
e107inc#2  /__w/e107/e107/e107_handlers/sitelinks_class.php:887
e107inc#3  /__w/e107/e107/e107_admin/includes/categories.php:22
e107inc#4  /__w/e107/e107/e107_tests/tests/unit/scriptsTest.php:140
e107inc#5  /__w/e107/e107/e107_tests/tests/unit/scriptsTest.php:36

--

There was 1 failure:

---------
1) e107Test: Load admin icons
 Test  tests/unit/e107Test.php:testLoadAdminIcons
E_16_FACEBOOK is missing from admin_icons_template
e107inc#1  /__w/e107/e107/e107_tests/tests/unit/e107Test.php:1054
Deltik added a commit that referenced this issue Sep 28, 2021
Prevents this flaky error:

---------
1) e_parse_shortcodeTest: Forum shortcodes
 Test  tests/unit/e_parse_shortcodeTest.php:testForumShortcodes
{INFO} != sc_info()
Failed asserting that two strings are equal.
- Expected | + Actual
@@ @@
'Welcome e107-cli<br />There are no new posts since your last visit.<br />
You last visited at  <br />
-			It is now Tuesday 28 September 2021 - 16:25:39'
+			It is now Tuesday 28 September 2021 - 16:25:38'
#1  /__w/e107/e107/e107_tests/tests/unit/e_parse_shortcodeTest.php:1656
#2  /__w/e107/e107/e107_tests/tests/unit/e_parse_shortcodeTest.php:1147
#3  e_parse_shortcodeTest->testForumShortcodes
#4  {closure}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: testing required Someone needs to confirm this issue's existence and write a test to prevent the fix from regressing.
Projects
None yet
Development

No branches or pull requests

3 participants