Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global lans for plugins #50

Closed
CaMer0n opened this issue Dec 12, 2012 · 9 comments
Closed

Global lans for plugins #50

CaMer0n opened this issue Dec 12, 2012 · 9 comments
Assignees
Labels
type: enhancement An improvement or new feature request
Milestone

Comments

@CaMer0n
Copy link
Member

CaMer0n commented Dec 12, 2012

Currently plugins have no simple way to assign a LAN which may be used site-wide for everything from sitelinks to extended-user fields.

@ghost ghost assigned CaMer0n and Moc Dec 12, 2012
@CaMer0n
Copy link
Member Author

CaMer0n commented Dec 13, 2012

This has been added, but all plugins need to be updated with an English_global.php file and plugin.xml modified to use the terms within it.

@Moc
Copy link
Member

Moc commented Dec 15, 2012

@CaMer0n @SecretR Are all language files automatically detected? ie. Can we remove all occurrences in every plugin.xml?

@CaMer0n
Copy link
Member Author

CaMer0n commented Dec 17, 2012

[Language]_log.php and [Language]_install.php and [Language]_global.php are auto-detected. Currently about 11 plugin.xml files still have reference to 'languageFiles' which need to be removed.

CaMer0n added a commit that referenced this issue Dec 17, 2012
Moc added a commit that referenced this issue Dec 19, 2012
Moc added a commit that referenced this issue Dec 19, 2012
Moc added a commit that referenced this issue Dec 19, 2012
@Moc
Copy link
Member

Moc commented Dec 19, 2012

Done a whole bunch, think I got them all. Loads more plugin clean-up to do: useless LAN -> need replacing by general/global ones. Commented some of those useless LANs out, so there may be broken LAN references in the plugins admin. (related to #6)

@nlstart
Copy link
Contributor

nlstart commented Dec 19, 2012

What should be done with the plugin.xml texts?

@Moc
Copy link
Member

Moc commented Dec 19, 2012

What do you mean with 'texts'?

@nlstart
Copy link
Contributor

nlstart commented Dec 20, 2012

E.g. the plugin.xml description is not overwritten by the text from the English_global.php.

@Moc
Copy link
Member

Moc commented Dec 21, 2012

I see what you mean. @CaMer0n ?

@Moc
Copy link
Member

Moc commented Dec 22, 2012

Talked to Cameron. They should remain there as they are used on e107.org. The PHP files are not loaded on e107.org for security reasons so the global LAN's cannot be used there.

Within each e107 installation in the plugin manager, both are used:
Installed > uses LANs
Not Installed > uses LANs
Search > uses English (strings in-between the description tags)

@CaMer0n CaMer0n closed this as completed Jan 21, 2013
CaMer0n pushed a commit that referenced this issue May 12, 2018
@Deltik Deltik removed the status: pending This issue is being worked on or is in the backlog to be fixed. label Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement An improvement or new feature request
Projects
None yet
Development

No branches or pull requests

4 participants