Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for tests failing after PHP 8.2 released #4921

Merged
merged 3 commits into from Dec 11, 2022

Conversation

Deltik
Copy link
Member

@Deltik Deltik commented Dec 11, 2022

Motivation and Context

Tests are broken because the Xdebug version for PHP 7.2 and newer was not pinned, and Xdebug 3.2.0 removed support for PHP versions below 8.0.

Description

  • Pin Xdebug 3.1.6 for PHP 7.2 through PHP 7.4
  • Remove automated acceptance tests, which are broken for a different reason that hasn't been investigated fully yet
  • Start testing MariaDB 10.6
  • Start testing MariaDB 10.10

Note: PHP 8.2 is not yet added as a service version yet because of an interpreter bug:

$ date ; time php -d xdebug.mode=coverage ./vendor/bin/codecept run unit --steps ; date
Sat Dec 10 07:50:37 PM CST 2022
Codeception PHP Testing Framework v4.2.2 https://helpukrainewin.org
Powered by PHPUnit 9.5.27 by Sebastian Bergmann and contributors.

Unit Tests (605) ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
✔ validatorClassTest: Validate fields (0.05s)
- e107pluginTest: Get plugin recordphp: /tmp/php-build/source/8.2.0/Zend/zend_builtin_functions.c:763: zif_get_object_vars: Assertion `!(((__ht)->u.flags & (1<<2)) != 0)' failed.
Aborted

real    0m3.091s
user    0m1.464s
sys     0m0.850s
Sat Dec 10 07:50:40 PM CST 2022

How Has This Been Tested?

Tests pass again

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist

Planning to add them back when I make them more robust…
Xdebug 3.2.0 and newer dropped support for PHP 7.2 through PHP 7.4.

Source: https://bugs.xdebug.org/bug_view_page.php?bug_id=00002014
PHP 8.2: Not yet because of a segmentation fault:

```
php: /tmp/php-build/source/8.2.0/Zend/zend_builtin_functions.c:763: zif_get_object_vars: Assertion `!(((__ht)->u.flags & (1<<2)) != 0)' failed.
```
@Deltik Deltik requested a review from CaMer0n December 11, 2022 01:51
@codeclimate
Copy link

codeclimate bot commented Dec 11, 2022

Code Climate has analyzed commit 8ae4fe1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 34.7% (0.3% change).

View more on Code Climate.

@CaMer0n
Copy link
Member

CaMer0n commented Dec 11, 2022

Thank you @Deltik !! 👍 🥇

@CaMer0n CaMer0n merged commit 0ae82a7 into e107inc:master Dec 11, 2022
@Deltik Deltik deleted the hotfix/tests/unit branch December 11, 2022 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants