#4929: Fix type mismatch in usage of e107forum::getForumClassMembers()
#4931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Members()` Also, `e107forum::getForumClassMembers()` is now documented and deprecated because it has unintuitive return values. Fixes: e107inc#4929
|
Code Climate has analyzed commit 566cde0 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 0.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 34.7% (0.1% change). View more on Code Climate. |
|
Thank you @Deltik ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Fixes: #4929
Description
e107forum::getForumClassMembers()is now documented and deprecated because it has unintuitive return values.The single usage of this method in
plugin_forum_viewforum_shortcodes::sc_viewable_by()has been corrected to account for the mixed return type.How Has This Been Tested?
Manually verified that there is no uncaught exception when running the steps to reproduce #4929:
Types of Changes
Checklist