Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce automated acceptance tests #4943

Merged
merged 2 commits into from Jan 13, 2023

Conversation

Deltik
Copy link
Member

@Deltik Deltik commented Jan 5, 2023

Motivation and Context

Acceptance tests were previously disabled in 9d4aba8 because they were not scalable beyond an old base image and that old image stopped working.

Description

Instead of building an image to simulate a basic shared hosting environment, acceptance tests will now apply a state file on preexisting community images and then deploy e107 onto them.

For more realistic simulation, systemd with Podman is used in the initial few images that the new acceptance tests start up.

How Has This Been Tested?

The e107 acceptance tests now run on Ubuntu 20.04 and Ubuntu 22.04 for starters. They were previously running on a custom Ubuntu 20.04 image built one time two years ago.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist

@Deltik Deltik force-pushed the hotfix/tests/acceptance branch 2 times, most recently from e296b6c to f6a225a Compare January 8, 2023 17:32
@codeclimate
Copy link

codeclimate bot commented Jan 8, 2023

Code Climate has analyzed commit f6a225a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 34.6% (0.5% change).

View more on Code Climate.

@CaMer0n
Copy link
Member

CaMer0n commented Jan 13, 2023

Thanks 👍

@CaMer0n CaMer0n merged commit 21de308 into e107inc:master Jan 13, 2023
@Deltik Deltik deleted the hotfix/tests/acceptance branch January 13, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants