Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide unwanted minor activities in the sidebar #551

Open
evanp opened this issue Apr 8, 2013 · 8 comments
Open

Hide unwanted minor activities in the sidebar #551

evanp opened this issue Apr 8, 2013 · 8 comments
Labels
Milestone

Comments

@evanp
Copy link
Contributor

evanp commented Apr 8, 2013

You see your friends' minor activities even if they're from an app you don't like.

Users should be able to hide activities by app. So, say, no Open Farm Game updates.

@macno
Copy link
Contributor

macno commented May 1, 2013

I'm trying to implement it. Where could I put the user's "apps blacklist" ?

@evanp
Copy link
Contributor Author

evanp commented May 1, 2013

So, here are my thoughts on the subject:

  • There's a property of each activity that is the identity of the generating app. So that'd be something like activity.generator. It's got an ID, so that would be a good thing to filter on.
  • I think there are two ways of implementing this kind of blocking. The first is to prevent the activity from ever getting into the user's inbox. A check in https://github.com/e14n/pump.io/blob/master/lib/model/user.js#L647 would be a good place to start.
  • The other is to allow the blocked activities to get into the inbox, but filter them out. We already do some filtering around https://github.com/e14n/pump.io/blob/master/lib/streams.js#L162, so that might be a good place to do some filtering by app.
  • Would a stream work for storing the apps blocklist? It might not be necessary. I think just storing an array of IDs would work too.

As for UI, yes, we'll need a Web form like the settings and accoutn

My big concern is that this is a lot of work, and it doesn't seem like the right time to do it. I for one would much rather have a working Android app than filter out people watering onions.

Could we do a quick fix on this and just turn off the watering notifications on OFG? That might turn down the noise a lot?

@pztrn
Copy link

pztrn commented May 1, 2013

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

01.05.2013 16:58, Evan Prodromou пишет:

So, here are my thoughts on the subject:

  • There's a property of each activity that is the identity of the
    generating app. So that'd be something like activity.generator.
    It's got an ID, so that would be a good thing to filter on. * I
    think there are two ways of implementing this kind of blocking. The
    first is to prevent the activity from ever getting into the user's
    inbox. A check in
    https://github.com/e14n/pump.io/blob/master/lib/model/user.js#L647
    would be a good place to start. * The other is to allow the blocked
    activities to get into the inbox, but filter them out. We already
    do some filtering around
    https://github.com/e14n/pump.io/blob/master/lib/streams.js#L162, so
    that might be a good place to do some filtering by app. * Would a
    stream work for storing the apps blocklist? It might not be
    necessary. I think just storing an array of IDs would work too.

As for UI, yes, we'll need a Web form like the settings and
accoutn

My big concern is that this is a lot of work, and it doesn't seem
like the right time to do it. I for one would much rather have a
working Android app than filter out people watering onions.

Could we do a quick fix on this and just turn off the watering
notifications on OFG? That might turn down the noise a lot?

--- Reply to this email directly or view it on GitHub:
#551 (comment)

And about planting also ;)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJRgRQ7AAoJEMUnU+sbGBaIDgoH/RYzc81MzbLECrjallKf43gl
lXxESbzxf+9TqXy49ChsJ9qu0noszcma2rztTlz/01ECtGKFD+7hokSpgCK+u5n+
YdQxCKePnx8+cMKBuWc/9nIHPaLlvm0iGgV3hZ4StXOZ0IQRhrDzHB+iJAUufrUB
FlBcOYDp+aTG2aipn/SZK6AtqnQpqnonC+PdY6lDs0Wq7kNBSKdC5Xgu40g2YsOG
5iG+LWX7h5hHa6rAjoiZFcBoDE4gbVcXG295INycITaCvJtqOlYgUqkn5rQyI6Vx
BKck4uVRV4y3G5u+vjxGNAxq3JKzcJgSzHHtRbtuaEFXeiIk4Za1TccPIaZrZKM=
=ge6D
-----END PGP SIGNATURE-----

@pztrn
Copy link

pztrn commented May 1, 2013

Oh, sorry for PGPing my reply) What about turning off notifications about planting also?

@evanp
Copy link
Contributor Author

evanp commented May 1, 2013

@pztrn c'mon, man. Really?

@pztrn
Copy link

pztrn commented May 1, 2013

It's a proposal and nothing more :) What's the point of this messages - I don't understand at all. Or, at least, make an option in OFG users settings about "not sending".

@evanp
Copy link
Contributor Author

evanp commented May 1, 2013

@pztrn the whole point is to show how social games can work on the pump network.

Most social games have a viral loop; you show people in the network that you're playing the game, and they click the link to see what you're doing. It's supposed to be fun.

@m4rch
Copy link

m4rch commented May 1, 2013

wouldn't it be enough for a start to minimize OFG's updates to one per each? like when i'm watering 20+ fields of strawberries, not 20+ updates but only one 'march watered strawberries'?

@larjona larjona added the webui label Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants