-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
function(checkfiletype) in site.story not overriding function in common.story E2G 5.5.1pre #735
Comments
The function override facility is basic to the storyboard facility. Can you turn on storyboardtrace on a test system and if it is not obvious what is wrong, post the result with your site.story and the story for the filtergroup. Message numbers: as exceptions do not display a message to the user messsage_nos are not usually needed and as as the function is deploying reverse logic the message number should be included in the storyboard condition setting the block - so the final line should read 'if(true,,750) return setblock' I'll correct this in later versions. |
I did a story trace and there was nothing in the logs. I will look at this again when I have fully completed all the work I am doing on E2guardian as there may have been some change during the setup process that I have not documented that is causing the issue. |
I have done some more work on this and compared E2guardian 5.5.1pre with E2guardian 5.4.5r and I can confirm that the results are the same regardless of E2guardian version. It is a bit confusing because it depends on how the file is stored on the website and whether you are using banned or exceptions.
SB warning: Defined list mimelist:bannedmime is not referenced in storyboard ....examplef1.story
However another website where you can download a zip file but the url link does not contain the word .zip - then it ignores the bannedextensionlist and just uses the exceptions. Hopefully that makes sense. This was quite confusing to work out as it was not obvious what was happening initially.
|
Instead of using bannedextensionlist and bannedmimetypelist I want to move to exceptionsextentionlist and exceptionmimetypelist as this would be more secure.
I have uncommented the following in site.story. However extensions are still being banned based on what is in the bannedextensionlist file. I am aware that there is a function(checkfiletype) in the common.story file which bans extensions and mimetypes based on what are in the banned files. It would seem that the function(checkfiletype) in site.story is not overriding the function in common.story.
If you only want exception extensions/mime filetypes to be allowed
then uncomment the following 4 lines
function(checkfiletype)
if(mimein, exceptionmime) return false
if(extensionin, exceptionextension) return false
if(true) return setblock
I presume that I need to set the messageno=900 for exceptionextensionlist and messageno=800 for exceptionmimetypelist in the e2guardianfx.conf files as this bit of coding is missing for exceptions, but not the banned lists.
The text was updated successfully, but these errors were encountered: