Fix default size of maxcontentramcachescansize option in configs/e2guardian.conf.in #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…content_ramcache_scan_size.
…s of maxcontentfiltersize and maxcontentramcachesize obey to the requirements in the (inline) documentation. See Debian bug https://bugs.debian.org/998430 (which is a little hard to read, but the reported issue could be confirmed).
I think this issue never popped up, because the non-initialized maxcontentramcachescansize masked the second (2048 no <= 2000) problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at Debian bug report https://bugs.debian.org/998430 I spotted two flaws in the upstream code.
First flaw is that maxcontentramcachescansize's default value never gets initialized (first patch in this PR).
Second flaw is that if it would get initialized correctly, it would get initialized to a value that is lower than maxcontentfiltersize. However, for maxcontentfiltersize the documentation says:
However, maxcontentfiltersize is 2048 by default, whereas maxcontentramcachescansize is only 2000 by default.