Bugfix/generic geodata #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 12, 2023 16:50
…pipes were considered. Adapted it accordingly that any branch component is considered.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #568 +/- ##
===========================================
+ Coverage 85.06% 85.12% +0.05%
===========================================
Files 90 90
Lines 6181 6179 -2
===========================================
+ Hits 5258 5260 +2
+ Misses 923 919 -4 ☔ View full report in Codecov by Sentry. |
dlohmeier
previously approved these changes
Nov 3, 2023
| #mask = _get_element_mask_from_nodes(net, "pipe", ["from_junction", "to_junction"], junctions) | ||
| #for pipe in net.pipe[mask].itertuples(): | ||
| # g.add_edge(pp_junction_mapping[pipe.from_junction], pp_junction_mapping[pipe.to_junction], | ||
| # weight=pipe.length_km) |
There was a problem hiding this comment.
If this part is not needed, I think we should just delete it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only pipes were considered so far. Now all Branch components are considered.