Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclear comments in create_measurement() #998

Closed
HubYZ opened this issue Nov 19, 2020 · 2 comments
Closed

Unclear comments in create_measurement() #998

HubYZ opened this issue Nov 19, 2020 · 2 comments
Assignees
@wangzhenassd
Labels
state estimation

Comments

@HubYZ
Copy link
Contributor

HubYZ commented Nov 19, 2020

The comments (line 3310 in pandapower/create.py) in create_measurement() say
"value (float) - Measurement value. Units are "MW" for P, "MVar" for Q, "p.u." for V,
"kA" for I. Generation is a positive bus power consumption, injection negative"

"Generation is a positive bus power consumption, injection negative"
So, what does this mean? Please re-comment this function, and place a clear one.
@wangzhenassd wangzhenassd self-assigned this Nov 20, 2020
@wangzhenassd
Copy link
Contributor

Hi, I will have a look on that.

wangzhenassd added a commit to wangzhenassd/pandapower that referenced this issue Nov 20, 2020
@wangzhenassd
Update description in create_measurement according to e2nIEE#998
ff87a51
wangzhenassd added a commit that referenced this issue Nov 20, 2020
@wangzhenassd
Merge pull request #1003 from wangzhenassd/develop
f924be1 
Update description in create_measurement according to #998
@wangzhenassd
Copy link
Contributor

Fixed by #1003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wangzhenassd wangzhenassd

Labels
state estimation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HubYZ @wangzhenassd