Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logdev which are unopened during recovery. #398

Merged
merged 1 commit into from
May 3, 2024

Conversation

sanebay
Copy link
Contributor

@sanebay sanebay commented Apr 30, 2024

Removing repl dev will remove the logdev. If logdev or log store are not opened during, they are marked as ununsed and deleted. Remove chunks from the journal descriptor. Remove the logdev metablk.

  1. Fix a regression in device manager where vdev size was not zero. Use after move.
  2. Add UT to delete the logdev and delete it if its unopened during recovery.
  3. logdev can be called during delete of repldev. If repl dev is marked for delete, repldev wont open logdev's during recovery and those are deleted. We first release all chunks and then metablks related to logdev.

hkadayam
hkadayam previously approved these changes May 2, 2024
Copy link
Collaborator

@hkadayam hkadayam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Removing repl dev will remove the logdev. If logdev or log
store are not opened during, they are marked as ununsed and
deleted. Remove chunks from the journal descriptor.
Remove the logdev metablk.
@sanebay sanebay linked an issue May 3, 2024 that may be closed by this pull request
@sanebay sanebay merged commit 42c5774 into eBay:master May 3, 2024
21 checks passed
@sanebay sanebay deleted the logdev_remove branch May 3, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add remove logdev feature
3 participants