Skip to content
This repository has been archived by the owner on Aug 1, 2019. It is now read-only.

Add support for Carthage #42

Merged
merged 1 commit into from
Sep 21, 2016
Merged

Add support for Carthage #42

merged 1 commit into from
Sep 21, 2016

Conversation

a-ono
Copy link
Contributor

@a-ono a-ono commented Sep 9, 2016

Cartfile:

github "a-ono/NMessenger" "carthage-support"

Add AsyncDisplayKit.framework and NMessenger.framework to your project.

@DavidSchechter
Copy link
Contributor

Please rebase and update the PR so we can merge

@DavidSchechter
Copy link
Contributor

@a-ono Please rebase and update the PR so we can merge
If you do not rebase, this PR will be closed

@a-ono
Copy link
Contributor Author

a-ono commented Sep 20, 2016

I just updated the PR.

@atainter atainter merged commit d6c2b63 into eBay:master Sep 21, 2016
@DavidSchechter
Copy link
Contributor

DavidSchechter commented Sep 27, 2016

@a-ono the project cannot be built now. It's saying it can find AsyncDisaplyKit.
Why is there a nMessenger-iOS target and scheme?

This was referenced Sep 27, 2016
@a-ono
Copy link
Contributor Author

a-ono commented Sep 28, 2016

Probably you should run carthage bootstrap.

Why is there a nMessenger-iOS target and scheme?

Carthage requires a framework project that has shared schemes.
https://github.com/Carthage/Carthage#supporting-carthage-for-your-framework

@DavidSchechter
Copy link
Contributor

DavidSchechter commented Sep 28, 2016

@a-ono why do I need to run carthage bootstrap?
I am using cocoapods. Why can't I run pod install and the project builds like before this PR was merged?
One should not block the other from working.

@a-ono
Copy link
Contributor Author

a-ono commented Sep 28, 2016

@DavidSchechter I created the pull request #52.

@DavidSchechter
Copy link
Contributor

@a-ono I merged #52. It fixes the issue. Thanks a lot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants