Allow copy constructor for raft_params
#10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `raft_params` is just a simple structure and there is no reason to block copy operation. * Modified related APIs.
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=============================================
- Coverage 82.458% 82.045% -0.413%
=============================================
Files 56 56
Lines 4019 3999 -20
=============================================
- Hits 3314 3281 -33
- Misses 705 718 +13 |
JackyWoo
pushed a commit
to JackyWoo/NuRaft
that referenced
this pull request
Sep 30, 2022
Enable ipv6 in NuRaft
xiaoxichen
pushed a commit
to xiaoxichen/NuRaft
that referenced
this pull request
Jan 16, 2024
gRPC Factory per WorkerPool
xiaoxichen
pushed a commit
to xiaoxichen/NuRaft
that referenced
this pull request
Jan 16, 2024
completion cb is part of rpc data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
raft_paramsis just a simple structure and there is no reason toblock copy operation.
Modified related APIs.