Make token getters not return null, but empty optional #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I feel that returning null instead of an empty optional is counter intuitive. At it makes it necessary to actually do two checks: 1. Check if the optional is null 2. Check if the optional is empty
Sorry, should have tested
This in relation to my first pull request
It can not be generally assumed that the login name is identical to the preferred username. On a newly created production user, the preferred username is the first name + four digits. Where as I log in with the email address. So This check is not valid in my opinion.
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=========================================
- Coverage 80.31% 80% -0.32%
- Complexity 85 86 +1
=========================================
Files 12 12
Lines 386 390 +4
Branches 28 28
=========================================
+ Hits 310 312 +2
- Misses 56 57 +1
- Partials 20 21 +1
Continue to review full report at Codecov.
|
|
Thanks for the submission. LGTM. Will be made available in the next release version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel that returning null instead of an empty optional is counter intuitive.
At it makes it necessary to actually do two checks:
I hope this request will be positively received