Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Revert 'stricter TS - step 2 (#290)' #302

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

HenriqueLimas
Copy link
Collaborator

Checking still what is the issue, but isValidElement is one of the candidates. Currently for infotip is rendering two info icons

This reverts commit 1133449.

src/ebay-pagination/pagination.tsx Show resolved Hide resolved
src/ebay-pagination/pagination.tsx Show resolved Hide resolved
@HenriqueLimas HenriqueLimas changed the title FIX: Revert "stricter TS - step 2 (#290)" FIX: Revert 'stricter TS - step 2 (#290)' Dec 27, 2023
@HenriqueLimas HenriqueLimas reopened this Dec 27, 2023
Copy link
Contributor

@shpandian shpandian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did we already release the version? hope people are fine.

@shpandian shpandian merged commit 6f91fb2 into main Dec 27, 2023
13 of 15 checks passed
@shpandian shpandian deleted the revert-290-ts-stricter-step2 branch December 27, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants