Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING Skin17 #313

Merged
merged 3 commits into from
Jan 4, 2024
Merged

BREAKING Skin17 #313

merged 3 commits into from
Jan 4, 2024

Conversation

HenriqueLimas
Copy link
Collaborator

hlimas and others added 3 commits December 29, 2023 10:10
Co-authored-by: hlimas <hlimas@ebay.com>
Co-authored-by: hlimas <hlimas@ebay.com>
@shpandian
Copy link
Contributor

@HenriqueLimas how about rest of the skin changes? are all they in?

Copy link
Contributor

@shpandian shpandian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HenriqueLimas
Copy link
Collaborator Author

@shpandian all the other changes defined in the project are not required for the Breaking change, we can work as we go so we don't block SWU

@HenriqueLimas HenriqueLimas merged commit bd12614 into main Jan 4, 2024
7 checks passed
@HenriqueLimas HenriqueLimas deleted the skin17 branch January 4, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants