fix(education-notice/tips): added attributes to marko-tag.json

eBay · Mar 20, 2024 · ee86979 · ee86979
1 parent 036f328
commit ee86979
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 7 deletions.
diff --git a/src/components/ebay-education-notice/examples/base.marko b/src/components/ebay-education-notice/examples/base.marko
@@ -2,13 +2,10 @@ import type { Input as EducationNoticeInput } from "<ebay-education-notice>"
 export type Input = EducationNoticeInput;
 
 <ebay-education-notice ...input>
+    <@title>
+        <div>Educaiton title</div>
+    </@title>
     <p>
-        <strong>Error:</strong> Please take another look at the following:
-    </p>
-    <p>
-        <a href="#">Card number</a>,
-        <a href="#">Expiration date</a>
-        &amp;
-        <a href="#">Security code</a>
+        This is some education infromation
     </p>
 </ebay-education-notice>
diff --git a/src/components/ebay-education-notice/marko-tag.json b/src/components/ebay-education-notice/marko-tag.json
@@ -9,7 +9,22 @@
         "enum": ["attention", "confirmation", "information"]
     },
     "@icon": "string",
+    "@education-icon <educationIcon>": {
+        "attribute-groups": ["html-attributes"],
+        "@*": {
+            "targetProperty": null,
+            "type": "expression"
+        },
+        "@html-attributes": "expression"
+    },
+    "@variant": {
+        "enum": ["none", "prominent"]
+    },
+    "@icon-variant": {
+        "enum": ["none", "prominent"]
+    },
     "@a11y-text": "string",
+    "@a11y-dismiss-text": "string",
     "@a11y-role-description": "string",
     "@title <title>": {
         "attribute-groups": ["html-attributes"],

diff --git a/src/components/ebay-infotip/marko-tag.json b/src/components/ebay-infotip/marko-tag.json
@@ -42,6 +42,9 @@
     },
     "@aria-label": "string",
     "@variant": "string",
+    "@no-shift": "boolean",
+    "@not-inline": "boolean",
+    "@no-flip": "boolean",
     "@a11y-close-button-text": "string",
     "@icon <icon>": {
         "attribute-groups": ["html-attributes"],

diff --git a/src/components/ebay-tooltip/marko-tag.json b/src/components/ebay-tooltip/marko-tag.json
@@ -37,6 +37,9 @@
             "left-end"
         ]
     },
+    "@no-shift": "boolean",
+    "@not-inline": "boolean",
+    "@no-flip": "boolean",
     "@no-hover": "boolean",
     "@heading <heading>": {
         "attribute-groups": ["html-attributes"],

diff --git a/src/components/ebay-tourtip/marko-tag.json b/src/components/ebay-tourtip/marko-tag.json
@@ -37,6 +37,9 @@
             "left-end"
         ]
     },
+    "@no-shift": "boolean",
+    "@not-inline": "boolean",
+    "@no-flip": "boolean",
     "@a11y-close-text": "string",
     "@host <host>": {
         "attribute-groups": ["html-attributes"],