Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add toJSON to icon and cast as any #2094

Merged
merged 2 commits into from
Feb 14, 2024
Merged

fix: add toJSON to icon and cast as any #2094

merged 2 commits into from
Feb 14, 2024

Conversation

LuLaValva
Copy link
Member

@LuLaValva LuLaValva commented Feb 12, 2024

Description

  • Add the toJSON noop back to ebay-icon (it was removed in the TypeScript PR).
  • Hide types for toJSON from all interface Inputs and cast with as any before setting.
  • Fix tests for ebay-details

@LuLaValva LuLaValva self-assigned this Feb 12, 2024
agliga
agliga previously approved these changes Feb 13, 2024
@agliga agliga force-pushed the master branch 2 times, most recently from cc1bafb to d9d5335 Compare February 14, 2024 01:03
@LuLaValva LuLaValva changed the title fix: add toJSON to icon and add as any fix: add toJSON to icon and cast as any Feb 14, 2024
Copy link

changeset-bot bot commented Feb 14, 2024

🦋 Changeset detected

Latest commit: 3c4fa42

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agliga agliga merged commit 182b335 into master Feb 14, 2024
2 checks passed
@agliga agliga deleted the tojson-ts branch February 14, 2024 19:14
@github-actions github-actions bot mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants