Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(segmented-button): move types and validSizes to marko file #2100

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

LuLaValva
Copy link
Member

Description

  • Move types and validSizes to the .marko file from component.ts

@LuLaValva LuLaValva self-assigned this Feb 15, 2024
Copy link

changeset-bot bot commented Feb 15, 2024

🦋 Changeset detected

Latest commit: 859f89a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need all these changes?I thought we just need to change the import
Also, can we verify with Dylan that it's OK to import the template from the component?

@LuLaValva
Copy link
Member Author

Since we moved validSizes into the .marko file it made sense to also move the TypeScript interfaces (especially for consistency with other components that do the same thing). Without changing the validSizes from static to export, this is also the only place that we can access its type now.

@LuLaValva LuLaValva merged commit 277f12b into master Feb 15, 2024
2 checks passed
@LuLaValva LuLaValva deleted the segmented-buttons-import branch February 15, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants