Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chips-combobox): changed a11y text, icon, and added placeholder docs #2137

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Mar 18, 2024

Description

  • Fixed chips icon to be 12px
  • Added placeholder in docs. I don't think we need a11y placeholder, but it should be documented now
  • Added a11y text to include the option text (We might need to revisit this in case there are languages where remove item is gramatically incorrect, but for now, it's good enough)

References

#2116

@agliga agliga self-assigned this Mar 18, 2024
Copy link

changeset-bot bot commented Mar 18, 2024

🦋 Changeset detected

Latest commit: 4843588

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agliga agliga changed the title fix(chips-combobx): changed a11y text, icon, and added placeholder docs fix(chips-combobox): changed a11y text, icon, and added placeholder docs Mar 19, 2024
Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Would you mind also making it so that form submission is unconditionally blocked on chips-combobox on enter keypress? That was the other feedback from the accessibility review. It should be as simple as moving preventDefault out of its if statement in the keydown handler.

@agliga
Copy link
Contributor Author

agliga commented Mar 19, 2024

Changes look good! Would you mind also making it so that form submission is unconditionally blocked on chips-combobox on enter keypress? That was the other feedback from the accessibility review. It should be as simple as moving preventDefault out of its if statement in the keydown handler.

Done

Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one small change please...

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! 🚀

@agliga agliga merged commit 3d7ac4b into 13.3.0 Mar 20, 2024
2 checks passed
@agliga agliga deleted the chips-bugs branch March 20, 2024 16:17
This was referenced Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants