feat(date-textbox): added floating label support

[agliga]

Description

• Added floating label support for date-textbox (followed similar pattern to placeholder text)
• Added tests
• Note After adding server tests, navigator.language was breaking on the server. Added a guard against that.
• There is an open discussion about keeping the floating label always floated like we do with phone input. Regardless, if that is the way we are going to go, we will need a follow up after phone input is merged to add support for that.

References

#2035

Screenshots

[changeset-bot]

🦋 Changeset detected

Latest commit: bc4bbee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@ebay/ebayui-core	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[ArtBlue]

Everything looks good, except there's some weirdness with the option in the docs. It says, "If set then shows this text as the floating label," but entering a string doesn't work:

The docs are clear about setting the range of dates floating labels, but using the directions provided is still unclear about how to set it for one date.

[agliga]

Everything looks good, except there's some weirdness with the option in the docs. It says, "If set then shows this text as the floating label," but entering a string doesn't work:

The docs are clear about setting the range of dates floating labels, but using the directions provided is still unclear about how to set it for one date.

This is due to storybook not fully supporting text/array. If you put it in quotes, it works fine.

Im not sure what more we can say on this. If you have any suggestions, let me know or commit it.
This is using the same docs as inputPlaceholderText. It shows that it can be an array or text.

[agliga]

I added it, although I don't think its that big of a problem since this is only affecting people entering information in the storybook. In the code when they actually use it, all strings need to be in quotes anyways.

[ArtBlue]

I added it, although I don't think its that big of a problem since this is only affecting people entering information in the storybook. In the code when they actually use it, all strings need to be in quotes anyways.

Yea, I realize it's just a storybooks docs thing and works well otherwise, but if the docs appear to break when a dev uses those docs in the most intuitive way they know (just enter text) with no other directions otherwise (need to wrap the text in quotes) to help them be able to use the docs, it's far less than ideal.

I mean, part of our job is to help improve the DX, and clarity is a big part of that. Is it a big deal? Maybe. Maybe not. But does the change improve the DX? I would say that's categorically a 'yes.' When you consider that the change doesn't impact code in any way and simply provides clarity, I would say it would be wrong NOT to do it.