Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Contains a new component
ebay-notice
which constructs page and inline alerts.Context
As the alerts can be page or inline alerts (see ebay/skin) we want to get that as an input for customisation. Default is set to
page
when no input is provided.For a page alert we have a heading tag in the icon that provides it is ordering with a11y users. To provide that customisation we take the heading-tag as an input for customisation. Default is set to
h2
when no input is provided.As the alerts are differentiated into 3 types:
confirmation
,priority
andinformation
, we take the type as an input for the customisation. Default is set topriority
when no input is provided.References
This will complete issue #5
Screenshots
Page notice with type: priority
![screen shot 2018-03-06 at 5 39 39 pm](https://user-images.githubusercontent.com/6751429/37068810-6de48490-2165-11e8-8cc0-0f2872461331.png)
Inline notice with type: confirmation
![screen shot 2018-03-06 at 5 39 56 pm](https://user-images.githubusercontent.com/6751429/37068872-bf240f88-2165-11e8-86a9-34c0a0069fb5.png)