Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ebay-notice component #26

Closed
wants to merge 1 commit into from
Closed

Added ebay-notice component #26

wants to merge 1 commit into from

Conversation

sharma46bhawana
Copy link
Contributor

Description

Contains a new component ebay-notice which constructs page and inline alerts.

Context

  • As the alerts can be page or inline alerts (see ebay/skin) we want to get that as an input for customisation. Default is set to page when no input is provided.

  • For a page alert we have a heading tag in the icon that provides it is ordering with a11y users. To provide that customisation we take the heading-tag as an input for customisation. Default is set to h2 when no input is provided.

  • As the alerts are differentiated into 3 types: confirmation, priority and information, we take the type as an input for the customisation. Default is set to priority when no input is provided.

References

This will complete issue #5

Screenshots

Page notice with type: priority
screen shot 2018-03-06 at 5 39 39 pm

Inline notice with type: confirmation
screen shot 2018-03-06 at 5 39 56 pm

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 35

  • 0 of 0 (NaN%) changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.211%

Totals Coverage Status
Change from base Build 32: 0.0%
Covered Lines: 376
Relevant Lines: 418

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants