Increased browser support for tests #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanPiercey
force-pushed
the
increased-browser-support
branch
from
9074cd6
to
6c196d3
Compare
Pull Request Test Coverage Report for Build 2434
💛 - Coveralls |
ianmcburnie
approved these changes
Jun 26, 2019
|
p.s. I changed the scope of #497 to just firefox and safari. We can create a new ticket for IE and/or Edge if you think those are close too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates our tests to run in the following browsers:
Other browsers may not be possible with the current setup since some of them do not implement the features needed via the WebDriver spec. Still digging into to these to verify, however thought this was a good base to work off of.
References
Closes #497