Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate this package in favor of eslint:recommended #18

Open
austingardner opened this issue Jul 17, 2021 · 1 comment · May be fixed by #24
Open

Deprecate this package in favor of eslint:recommended #18

austingardner opened this issue Jul 17, 2021 · 1 comment · May be fixed by #24
Assignees

Comments

@austingardner
Copy link

It seems this repo hasn't had many updates for a long time. Should we keep it or should we just use a different set of rules?

At least we should upgrade the eslint version and set

"parserOptions": {
        "ecmaVersion": "latest"
}

So we can use the latest ecmascript versions.

@austingardner austingardner changed the title eslint-config-ebay has been neglected.. should we keep it or just use recommended? eslint-config-ebay has been neglected.. should we keep it or just use eslint:recommended? Jul 17, 2021
@giovannipds
Copy link

Your question makes sense, I have seen this kind of configuration in viewitem_nodestar, which does some useful stuff, like extending and overwriting:

{
    "extends": [
        "ebay",
        "plugin:testing-library/recommended",
        "plugin:jest/recommended"
    ],
    "parserOptions": {
        "ecmaVersion": 2020, // eslint-config-ebay uses 2017 which has this issue - https://github.com/eBay/eslint-config-ebay/issues/13
        "sourceType": "module" // To accommodate ES module imports
    },
    "overrides": [
        {
            "files": "**/test/**/*.browser.js",
            "extends": ["plugin:jest-dom/recommended"] // We want jest-dom recommended styles only for browser tests as some of the jest-dom helpers are not available in server tests.
        },
        {
            "files": "**/test/mock-data/**/*.js", // Disable few rules for mock data
            "rules" : {
                "max-len": "off"
            }
        }
    ],
    "globals": {
        "GH": "readonly"
    }
}

IMHO we should apply on top of this project community recommendations.

@ianmcburnie ianmcburnie changed the title eslint-config-ebay has been neglected.. should we keep it or just use eslint:recommended? Deprecate this package in favor of eslint:recommended May 31, 2024
DylanPiercey added a commit that referenced this issue Jun 1, 2024
@DylanPiercey DylanPiercey linked a pull request Jun 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants