Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monitor and Update 2/3 support #42

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

trozet
Copy link

@trozet trozet commented Sep 10, 2021

No description provided.

trozet and others added 2 commits September 10, 2021 12:11
Co-authored-by: Numan Siddique <nusiddiq@redhat.com>
Co-authored-by: Dan Williams <dcbw@redhat.com>
Signed-off-by: Tim Rozet <trozet@redhat.com>
Signed-off-by: Tim Rozet <trozet@redhat.com>
@trozet
Copy link
Author

trozet commented Sep 10, 2021

@hzhou8 @dcbw @numansiddique @girishmg PTAL

Numan, I copied your schema changes in here blindly. Seems like a heavy change, did you get those from ovn-org/libovsdb?

@numansiddique
Copy link

@hzhou8 @dcbw @numansiddique @girishmg PTAL

Numan, I copied your schema changes in here blindly. Seems like a heavy change, did you get those from ovn-org/libovsdb?

Yeah. I just copied it from ovn-org/libovsdb AS IS.

We need that to figure out what is the type of each column to init the column values to default ones if not present in the initial dump.

@dcbw
Copy link

dcbw commented Sep 15, 2021

LGTM

@hzhou8
Copy link

hzhou8 commented Sep 21, 2021

Thanks @trozet ! I saw some build errors. Seems there are more dependencies not ported?

./native.go:112:26: na.schema.GetColumn undefined (type *DatabaseSchema has no field or method GetColumn)
./native.go:128:26: na.schema.GetColumn undefined (type *DatabaseSchema has no field or method GetColumn)
./ovs_integration_test.go:298:14: cannot use notifier (type Notifier) as type NotificationHandler in argument to ovs.Register:
	Notifier does not implement NotificationHandler (missing Update2 method)
./ovs_integration_test.go:329:14: cannot use notifier (type Notifier) as type NotificationHandler in argument to ovs.Register:
	Notifier does not implement NotificationHandler (missing Update2 method)
./ovs_integration_test.go:332:20: cannot use notifier (type Notifier) as type NotificationHandler in argument to ovs.Unregister:
	Notifier does not implement NotificationHandler (missing Update2 method)
./schema_test.go:129:10: unknown field 'Max' in struct literal of type ColumnType (but does have max)
./schema_test.go:130:10: unknown field 'Min' in struct literal of type ColumnType (but does have min)
./schema_test.go:137:10: unknown field 'Max' in struct literal of type ColumnType (but does have max)
./schema_test.go:138:10: unknown field 'Min' in struct literal of type ColumnType (but does have min)
./schema_test.go:145:10: unknown field 'Max' in struct literal of type ColumnType (but does have max)
./schema_test.go:145:10: too many errors
FAIL	github.com/ebay/libovsdb [build failed]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants