Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] Build test lab..... #64

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[DNM] Build test lab..... #64

wants to merge 1 commit into from

Conversation

xiaoxichen
Copy link
Contributor

SM needs to return leader in both response of some API call as well as PGStat report.

This helps client(of SM) to know up-to-date leader and send requests to leader.

@xiaoxichen xiaoxichen marked this pull request as draft January 19, 2024 03:15
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6abaabb) 72.56% compared to head (939c257) 74.93%.

Files Patch % Lines
src/lib/repl_service_ctx.cpp 20.00% 2 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   72.56%   74.93%   +2.37%     
==========================================
  Files          21       20       -1     
  Lines         831      802      -29     
  Branches       95       92       -3     
==========================================
- Hits          603      601       -2     
+ Misses        168      137      -31     
- Partials       60       64       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

SM needs to return leader in both response of some API call as well as PGStat report.

This helps client(of SM) to know up-to-date leader and send requests to leader.

Signed-off-by: Xiaoxi Chen <xiaoxchen@ebay.com>
@xiaoxichen xiaoxichen changed the title Exposing Leader to upper layer [DNM] Build test lab..... Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants