Skip to content
This repository has been archived by the owner on Jan 1, 2019. It is now read-only.

Param setup bug in ParallelClient #60

Merged
merged 1 commit into from Jun 18, 2017
Merged

Param setup bug in ParallelClient #60

merged 1 commit into from Jun 18, 2017

Conversation

kination
Copy link
Contributor

Hello!
As I see isClosed is described as 'marked when all resources are released/not initialized.' but it is being set as true after re-init. Please look on and let me know if I'm correct on this.

Thanks.

@codecov-io
Copy link

Codecov Report

Merging #60 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #60      +/-   ##
===========================================
+ Coverage     95.19%   95.3%   +0.11%     
- Complexity     1062    1064       +2     
===========================================
  Files            83      83              
  Lines          3368    3368              
  Branches        260     260              
===========================================
+ Hits           3206    3210       +4     
+ Misses           68      63       -5     
- Partials         94      95       +1
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/parallec/core/ParallelClient.java 96.19% <100%> (-1.91%) 26 <0> (-1)
.../java/io/parallec/core/actor/ExecutionManager.java 93.47% <0%> (+0.43%) 44% <0%> (+1%) ⬆️
...n/java/io/parallec/core/actor/OperationWorker.java 90.96% <0%> (+3.22%) 43% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7df7544...b9445cd. Read the comment docs.

@jeffpeiyt jeffpeiyt merged commit baf5ac1 into eBay:master Jun 18, 2017
@jeffpeiyt
Copy link
Contributor

LGTM. Thanks so much @djKooks !!

@kination kination deleted the param-fix branch June 19, 2017 00:31
@kination
Copy link
Contributor Author

@jeffpeiyt Thanks for review!

@jeffpeiyt
Copy link
Contributor

Released 0.10.5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants