Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTA large alignment issue #1890

Closed
HenriqueLimas opened this issue Oct 3, 2022 · 1 comment · Fixed by #1917
Closed

CTA large alignment issue #1890

HenriqueLimas opened this issue Oct 3, 2022 · 1 comment · Fixed by #1917
Assignees
Labels
module: cta-button priority: 3 Fix should be on roadmap or backlog type: bug
Projects
Milestone

Comments

@HenriqueLimas
Copy link
Contributor

When using a cta-btn--large, the alignment of the content is not centered to the button:

<a href="http://www.ebay.com" class="cta-btn cta-btn--large">
   <span class="cta-btn__cell">
      <span>CTA button</span>
      <svg aria-hidden="true" class="icon icon--cta" focusable="false">
         <use xlink:href="#icon-cta"></use>
      </svg>
   </span>
</a>

Screen Shot 2022-10-03 at 4 35 13 PM

@agliga agliga added type: bug priority: 3 Fix should be on roadmap or backlog module: cta-button labels Oct 4, 2022
@agliga
Copy link
Contributor

agliga commented Oct 4, 2022

Adding a display: inline-flex; to the cta button should fix this issue.

@agliga agliga added this to To do in 15.2.0 via automation Oct 19, 2022
@agliga agliga added this to the 15.2.0 milestone Oct 26, 2022
@saiponnada saiponnada moved this from To do to In progress in 15.2.0 Nov 1, 2022
@saiponnada saiponnada linked a pull request Nov 1, 2022 that will close this issue
9 tasks
@agliga agliga moved this from In progress to Pull Request in 15.2.0 Nov 4, 2022
@saiponnada saiponnada moved this from Pull Request to Done in 15.2.0 Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: cta-button priority: 3 Fix should be on roadmap or backlog type: bug
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants