1401 Tooltip Bottom and Bottom Left Arrow Fix #1404
Conversation
austingardner
changed the title
austingardner
force-pushed
the
1401-tooltip-experiment
branch
from
48745e4
to
b98ebe8
Compare
|
I'm not sure why the buttons in bottom right and top right examples are over to the right hand side of the page..? |
| .pointer-bottom-left(); | ||
| } | ||
|
|
||
| .tooltip__pointer--bottom { | ||
| .tooltip__pointer--bottom, | ||
| span.tooltip__pointer--bottom { |
There was a problem hiding this comment.
Hmm, it doesn't seem right to be hammering it with more specificity (and on just two of the pointer modifiers, not all of them). I'll take a look and try and see what changed between v10 and v11. I did a big refactor to try and normalise ds4 and ds6 so I probably broke something then (#1168)
There was a problem hiding this comment.
I've been trying to figure out where this override comes from:
The cascade order of the source looks good, so I suspected some overly aggressive minification, and yup when I disable minification things appears as expected:
@austingardner Can you see if you can play around with less minification settings to make it less aggressive?
Relevant line is: https://github.com/eBay/skin/blob/master/package.json#L30 EDIT: https://github.com/eBay/skin/blob/master/gulpfile.js#L59
There was a problem hiding this comment.
Yeah I can look into that!
There was a problem hiding this comment.
Sorry, this is the line I meant to point to: https://github.com/eBay/skin/blob/master/gulpfile.js#L59
|
So I think we can close this based on: less/less-plugin-clean-css#33 , right? |
Description
This fixes the direction of the arrow for the tooltip--bottom and tooltip--bottom-left variants. Previously the arrow was the same as in the top and top-left variants, because the
top: 7pxwas being applied and thetop: autowas not being applied.This was done by adding the
span.tooltip__pointer--bottom-leftandspan.tooltip__pointer--bottomselectors.References
Closes #1401
Screenshots