Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(data-viz): added data-viz color tokens #1957

Merged
merged 1 commit into from
Dec 9, 2022
Merged

feat(data-viz): added data-viz color tokens #1957

merged 1 commit into from
Dec 9, 2022

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Dec 8, 2022 •
edited

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Added data viz color tokens.

This should help unblock ebay ui Highcharts implementation.

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@ArtBlue ArtBlue self-assigned this Dec 8, 2022
@ArtBlue ArtBlue requested review from ianmcburnie, agliga, LuLaValva and martin-ebay and removed request for ianmcburnie December 8, 2022 18:47
martin-ebay
martin-ebay approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@martin-ebay martin-ebay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@agliga
Copy link
Contributor

agliga commented Dec 9, 2022

#1949 issue related to this PR

@ArtBlue ArtBlue merged commit 9a69cc4 into 15.3.0 Dec 9, 2022
@ArtBlue ArtBlue deleted the chart-tokens branch December 9, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agliga agliga agliga approved these changes

@martin-ebay martin-ebay martin-ebay approved these changes

@ianmcburnie ianmcburnie Awaiting requested review from ianmcburnie

@LuLaValva LuLaValva Awaiting requested review from LuLaValva

Assignees

@ArtBlue ArtBlue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArtBlue @agliga @martin-ebay