fix(carousel): removed will-change and transform to allow fixed passthrough #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmcburnie
approved these changes
Dec 15, 2022
agliga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1961
Description
will-changeandtransform. Both do not seem like they are needed. Removing them makes carousel work as before.Checklist
I verify the build is in a non-broken state
I verify all changes are within scope of the linked issue
I regenerated all CSS files under dist folder
I tested the UI in all supported browsers
I did a visual regression check of the components impacted by doing a Percy build and approved the build
I tested the UI in dark mode and RTL mode
I added/updated/removed Storybook coverage as appropriate