Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filter-menu-button, filter-button): improve container contrast #2014

Merged

Conversation

saiponnada
Copy link
Contributor

Fixes #1985

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Added default border for filter-button, filter-menu-button and filter-link in enabled state and a strong border on focus.

Notes

The color tokens being considered currently might not be accurate as per design requirements and might need an update.

Screenshots

filter-button, filter-link

Before
image

After
image

filter-menu-button

Before
image

After
image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@saiponnada saiponnada self-assigned this Mar 20, 2023
@saiponnada saiponnada marked this pull request as ready for review March 20, 2023 22:22
@saiponnada saiponnada merged commit 9cb5b39 into 16.0.0 Mar 20, 2023
@saiponnada saiponnada deleted the 1985-ebay-filter-menu-button-improve-container-contrast branch March 20, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants