Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(buttons): progress spinners in disabled buttons #2015

Merged
merged 1 commit into from
Mar 22, 2023
Merged

fix(buttons): progress spinners in disabled buttons #2015

merged 1 commit into from
Mar 22, 2023

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Mar 21, 2023 •
edited

Fixes #2010

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  1. Fixed the main a11y issue with spinners in primary disabled buttons, for both regular primary buttons as well as destructive primary buttons.
  2. I also fixed the wrong colors in progress spinners for primary buttons per Figma specs. The colors were wrong and inverted.
  3. I also fixed the primary destructive button spinner colors. They were incorrectly inverted.

Screenshots

Before

image

image

image

image

After

image

image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@ArtBlue ArtBlue added this to the 16.0.0 milestone Mar 21, 2023
@ArtBlue ArtBlue self-assigned this Mar 21, 2023
LuLaValva
LuLaValva approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me... I was a little confused about the motive until I saw this anti-pattern, but makes sense now.
image

@ArtBlue ArtBlue merged commit 903ae73 into 16.0.0 Mar 22, 2023
@ArtBlue ArtBlue deleted the 2010-bugprogress-spinner-fix-primary-disabled-button-color-contrast-issue branch March 22, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianmcburnie ianmcburnie ianmcburnie approved these changes

@agliga agliga agliga approved these changes

@LuLaValva LuLaValva LuLaValva approved these changes

@saiponnada saiponnada Awaiting requested review from saiponnada

Assignees

@ArtBlue ArtBlue

Labels
None yet
Projects
None yet
Milestone
16.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ArtBlue @ianmcburnie @agliga @LuLaValva