Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(calendar): some mild re-jigging of wording and examples #2024

Merged
merged 4 commits into from
Mar 29, 2023

Conversation

ianmcburnie
Copy link
Contributor

@ianmcburnie ianmcburnie commented Mar 29, 2023

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Some docs changes to improve the reading flow and layered in complexity from readonly to interactive.

I added some days that contain links in the readonly example.

I removed the calendar-month.html include as I found it easier just to edit things manually rather than deal with all the conditional logic in the template. This will become easier when we switch from Jekyll to Marko.

Notes

I also added in aria-pressed on buttons for start and end dates.

I made some minor edits to date-text.html box too, and notice we are missing an example that shows tow textboxes for a date range.

Screenshots

Screen Shot 2023-03-28 at 7 52 40 PM

Screen Shot 2023-03-28 at 7 52 50 PM

Screen Shot 2023-03-28 at 7 53 02 PM

Screen Shot 2023-03-28 at 7 53 13 PM

Screen Shot 2023-03-28 at 7 53 23 PM

Screen Shot 2023-03-28 at 7 53 32 PM

Screen Shot 2023-03-28 at 7 53 37 PM

Screen Shot 2023-03-28 at 7 53 45 PM

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue

@ianmcburnie ianmcburnie self-assigned this Mar 29, 2023
Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs changes Ian, this looks much better! Just a few typos and nitpicks, but once those are fixed I think this is a major improvement.

docs/_includes/calendar.html Outdated Show resolved Hide resolved
docs/_includes/calendar.html Outdated Show resolved Hide resolved
docs/_includes/calendar.html Outdated Show resolved Hide resolved
docs/_includes/calendar.html Outdated Show resolved Hide resolved
docs/_includes/calendar.html Show resolved Hide resolved
docs/_includes/calendar.html Show resolved Hide resolved
docs/_includes/calendar.html Outdated Show resolved Hide resolved
docs/_includes/date-textbox.html Outdated Show resolved Hide resolved
@ianmcburnie
Copy link
Contributor Author

Added 2nd example to date-textbox:

Screen Shot 2023-03-29 at 11 26 39 AM

@ianmcburnie ianmcburnie merged commit 8ab5f24 into 16.0.0 Mar 29, 2023
2 checks passed
@ianmcburnie ianmcburnie deleted the calendar-docs branch June 2, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants