Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove CDN #2025

Merged
merged 5 commits into from
Mar 29, 2023
Merged

feat: remove CDN #2025

merged 5 commits into from
Mar 29, 2023

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Mar 29, 2023

Description

This PR removes all the CDN changes and uses a github action to run npm run build and then deploy to Github pages

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue

NOTE, the jekyll actions is generated from github directly. The only thing I added was the nodejs and npm run build step which will generate the static directory. If there are issues with ruby on github (Since we always have issues with ruby locally) we can always just build the CSS part only.

docs/_layouts/default.html Show resolved Hide resolved
Copy link
Contributor

@ianmcburnie ianmcburnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Maybe also check for any old Jekyll vars that are no longer needed, like cdn_path.

We can probably also leverage this to build previews of upcoming releases... although maybe less relevant if we are moving to trunk based development.

@agliga agliga merged commit f266ca4 into 16.0.0 Mar 29, 2023
@ianmcburnie ianmcburnie deleted the remove-cdn branch June 2, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants