Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(page-grid): recovered subgrid, updated docs #2040

Merged
merged 5 commits into from
Apr 17, 2023

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Apr 12, 2023

Fixes #2030

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Brought back subgrid as the default internal grid mechanism.
  • Separated and retained and commented out (until official specifications/support) the nested grid mechanism.
  • Updated Skin docs with subgrid usage details.
  • Updated Skin docs with css properties and less constants info for easier referencing.

Screenshots

The distinction between nested grids and subgrids:
page-grid-subgrid-vs-nested-grid

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agliga
Copy link
Contributor

agliga commented Apr 12, 2023

One thing I did notice, but not sure if its due to this, examples are a bit messed up
Screen Shot 2023-04-12 at 4 46 31 PM
On the left side, the top nav bar is cut off and you cant see all items. Not sure if its intentional but looks bad.
On the right one, when you shrink it, it actually collapses strangely. When you increase the size it fits properly. Not sure if its an issue with implementation or just example.

We can do it in followup if needed though. I'm fine with this going as is.

@ArtBlue
Copy link
Contributor Author

ArtBlue commented Apr 13, 2023

One thing I did notice, but not sure if its due to this, examples are a bit messed up. On the left side, the top nav bar is cut off and you cant see all items. Not sure if its intentional but looks bad. On the right one, when you shrink it, it actually collapses strangely. When you increase the size it fits properly. Not sure if its an issue with implementation or just example.

We can do it in followup if needed though. I'm fine with this going as is.

This wasn't created by this PR and we don't technically support layouts < 320px, which is the only time this would occur, but I went ahead and fixed it anyway.

@ianmcburnie
Copy link
Contributor

Seems like the debug mode is having some issues. When I click the link the debug styles aren't showing up correctly.

@ArtBlue
Copy link
Contributor Author

ArtBlue commented Apr 14, 2023

Seems like the debug mode is having some issues. When I click the link the debug styles aren't showing up correctly.

Yep. The js that was turning on the debug mode in the elements was only targeting the first one it found. I fixed it.

@ArtBlue ArtBlue linked an issue Apr 17, 2023 that may be closed by this pull request
@ArtBlue ArtBlue merged commit 1cd0664 into 16.1.0 Apr 17, 2023
2 checks passed
@ArtBlue ArtBlue deleted the 2030-page-grid-recover-subgrid branch April 17, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

page-grid: recover subgrid
3 participants