Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added scrim tokens #2043

Merged
merged 3 commits into from
Apr 18, 2023
Merged

feat: added scrim tokens #2043

merged 3 commits into from
Apr 18, 2023

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Apr 13, 2023

Fixes #2042

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Added scrim tokens

Screenshots

Screen Shot 2023-04-13 at 3 41 57 PM

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@agliga agliga self-assigned this Apr 13, 2023
Copy link
Member

@LuLaValva LuLaValva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on my end

Copy link
Contributor

@ianmcburnie ianmcburnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we not using these tokens in our own Skin code anywhere? It would be good to switch out the current LESS variables and verify that the tokens work.

In dialog for example, I remember we needed "on/show" and "off/hide" variables to make things work:

https://github.com/eBay/skin/blob/master/src/less/mixins/private/dialog-mixins.less#L3

@ArtBlue
Copy link
Contributor

ArtBlue commented Apr 18, 2023

Ok, replaced the LESS vars with CSS props and verified things look good.

@LuLaValva LuLaValva merged commit 8c1e103 into 16.1.0 Apr 18, 2023
1 check passed
@LuLaValva LuLaValva deleted the scrim-tokens branch April 18, 2023 21:13
@ArtBlue ArtBlue linked an issue Apr 19, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tokens: add missing scrim tokens
4 participants