Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): adjusted icons used in storybook #2049

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Apr 20, 2023

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

This is fixing the icon usage issues found in visual regression (https://percy.io/f1364dca/eBay-Skin/builds/26768330). I also fixed a missing icon of an Icon Button story.

Notes

I reran another Percy build after the fixes to verify the updates match master: https://percy.io/f1364dca/eBay-Skin/builds/26799373

Screenshots

Issue
icon-size-issues

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@ArtBlue ArtBlue self-assigned this Apr 20, 2023
@ArtBlue ArtBlue merged commit 5c06f8c into 16.1.0 Apr 20, 2023
@ArtBlue ArtBlue deleted the fix-icons-in-16.1.0 branch April 20, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants