Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(button): add destructive red to borderless #2130

Merged
merged 1 commit into from Aug 9, 2023
Merged

fix(button): add destructive red to borderless #2130

merged 1 commit into from Aug 9, 2023

Conversation

ArtBlue
Copy link
Contributor

@ArtBlue ArtBlue commented Aug 8, 2023

Fixes #1910

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Added borderless destructive red to button/fake button

Screenshots

Before: (see issue)

After:
image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

@ArtBlue ArtBlue self-assigned this Aug 8, 2023
@ArtBlue ArtBlue merged commit 9e0691a into 16.6.0 Aug 9, 2023
@ArtBlue ArtBlue deleted the 1910-button-destructive-borderless-red branch August 9, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuLaValva LuLaValva LuLaValva approved these changes

@ianmcburnie ianmcburnie Awaiting requested review from ianmcburnie

@agliga agliga Awaiting requested review from agliga

Assignees

@ArtBlue ArtBlue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ArtBlue @LuLaValva