Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(phone-input): added sprites #2316

Merged
merged 3 commits into from
Apr 24, 2024
Merged

fix(phone-input): added sprites #2316

merged 3 commits into from
Apr 24, 2024

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Apr 23, 2024

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Updated phone input to use sprites instead of svgs. This is for performance reasons.

Screenshots

Screenshot 2024-04-23 at 11 49 14 AM Screenshot 2024-04-23 at 11 48 38 AM - [X] I verify the build is in a non-broken state - [X] I verify all changes are within scope of the linked issue - [X] I regenerated all CSS files under dist folder - [X] I tested the UI in all supported browsers - [X] I did a visual regression check of the components impacted by doing a Percy build and approved the build - [X] I tested the UI in dark mode and RTL mode - [X] I added/updated/removed Storybook coverage as appropriate

@agliga agliga self-assigned this Apr 23, 2024
Copy link

changeset-bot bot commented Apr 23, 2024

🦋 Changeset detected

Latest commit: 1c95976

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ArtBlue
Copy link
Contributor

ArtBlue commented Apr 23, 2024

We just need a changeset.

@agliga
Copy link
Contributor Author

agliga commented Apr 23, 2024

We just need a changeset.

Its okay if we dont have one. Since this is a change on top of the existing phone imput which has a changeset.

@ArtBlue ArtBlue merged commit a8c1352 into 17.4.0 Apr 24, 2024
1 check passed
@ArtBlue ArtBlue deleted the flag-sprites branch April 24, 2024 18:57
This was referenced Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants