Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed paddles on focus/hover for small screens #879

Merged
merged 1 commit into from Oct 9, 2019

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Oct 9, 2019

Description

Added CSS to make carousel paddles not show on hover for mweb. This was what initially was happening on pre 2.4, when we had different styles for mweb and dweb. Since they were combined, the paddles started to show.
Also removed focus-within on mweb

Context

  • Added media query for dweb to show paddles on hover and focus-within (mweb first!)
  • The cases where the paddles are explicitly shown still show
  • Focus on a paddle itself will show it, but not show the other one.

References

#875

@agliga agliga merged commit 59736a5 into 9.3.0 Oct 9, 2019
@agliga agliga deleted the carousel-small-paddles branch October 9, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants