-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIT-766-1 race condition bug fix #2687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace name field when it shouldn't
… on postback with validatio errors
…m being populated when pressing enter or the search button on address searches
…A question, and confirmation message
…e condition bug, added ajax loading indicator.
odensc
previously approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, if easy we should change the H3s on the confirmation page/computed messages to H2 so it doesn't skip a level.
odensc
previously approved these changes
Nov 30, 2023
odensc
pushed a commit
that referenced
this pull request
Jan 17, 2024
* SIT-765 enable place name field at Lucas' request * SIT-766 enable Place Name field * SIT-766 added disable place name autofill config option * SIT-766 final form updates * SIT-766 text formatting minor updates * SIT-766 updated confirmation verbiage, fixed bug that was clearing place name field when it shouldn't * SIT-766 tweaks to confirmation messages * SIT-766 fixed bug in location widget that caused point to be selected on postback with validatio errors * SIT-766 rearranged private property answers and updated verbiage * SIT-766 turned off previous submissions feature * SIT-766 fixed location widget bug that prevented location_address from being populated when pressing enter or the search button on address searches * SIT-766 update to private property next steps, vehicle next steps, ADA question, and confirmation message * SIT-766 added sentence to confirmation at Lucas' request * SIT-766-1 added timeout check when checking boundaries to prevent race condition bug, added ajax loading indicator. * SIT-766-1 added timeout checker on regions layer * SIT-766-1 hide loader when status or error modals are displayed. * SIT-766-1 removed commented code, cleanup * SIT-766-1 removed commented code, cleanup * SIT-766-1 added accessible loading message * SIT-766-1 fixed heading levels * SIT-766 Skip the deletion of multi-dev --------- Co-authored-by: Kevin Wang <xinju.wang@portlandoregon.gov>
odensc
added a commit
that referenced
this pull request
Apr 8, 2024
* CS-585 added Next Steps block for graffiti kit request, added waiver language. * CS-622 implement JSON form data field * CS-585 updated location widget to include layer type 'RegionHidden' so that regions are invisible in TSUP form. * CS-585 reverted change to tsup form, added options to graffiti resolution * CS-188 rebase on top of cs-622 * CS-585 updated variable names, updated widget logic for new geofencing functionality * CS-585 removed commented code from widget, removed custom submit button because it was preventing handlers from firing. * CS-585 removed geofencing from graffiti form; had been added for testing purposes only * CS-585 made 'What would you like to request' question optional. * CS-585 on graffiti form, fixed token for private property type; on resolution form, moved the other resolution to right below the resolution radios * CS-585 make require_city_limits_plus_parks default value FALSE * CS-585 fix geofencing defaults * CS-585 removed a big block of obsolete commented code * CS-585 removed typo * CS-188 add geocortex link, multiple change request ids * CS-188 clean up wording and add change request link to complex * CS-188 error logic changes * CS-188 update permit_location machine name + update ticket description formatting * CS-188 fix primary street not showing for simple permits * CS-188 update to new location picker + fix small date bug * PGOV-1020 adding My Events view to My Content (#2676) * PGOV-1020 adding My Events view to My Content * PGOV-1020 default sort and label change * PGOV-1029 Update remove_http_headers to prevent build failure (#2686) * SIT-766-1 race condition bug fix (#2687) * SIT-765 enable place name field at Lucas' request * SIT-766 enable Place Name field * SIT-766 added disable place name autofill config option * SIT-766 final form updates * SIT-766 text formatting minor updates * SIT-766 updated confirmation verbiage, fixed bug that was clearing place name field when it shouldn't * SIT-766 tweaks to confirmation messages * SIT-766 fixed bug in location widget that caused point to be selected on postback with validatio errors * SIT-766 rearranged private property answers and updated verbiage * SIT-766 turned off previous submissions feature * SIT-766 fixed location widget bug that prevented location_address from being populated when pressing enter or the search button on address searches * SIT-766 update to private property next steps, vehicle next steps, ADA question, and confirmation message * SIT-766 added sentence to confirmation at Lucas' request * SIT-766-1 added timeout check when checking boundaries to prevent race condition bug, added ajax loading indicator. * SIT-766-1 added timeout checker on regions layer * SIT-766-1 hide loader when status or error modals are displayed. * SIT-766-1 removed commented code, cleanup * SIT-766-1 removed commented code, cleanup * SIT-766-1 added accessible loading message * SIT-766-1 fixed heading levels * SIT-766 Skip the deletion of multi-dev --------- Co-authored-by: Kevin Wang <xinju.wang@portlandoregon.gov> * PGOV-620 Disable views_infinite_scroll (#2685) * PGOV-620 Disable views_infinite_scroll * PGOV-620 Fix page displays for upcoming and past events * PGOV-620 Allow editor to see unpublished events in related events page * PGOV-620 Restore multi-dev deletion code commented out for SIT-766-1 * PGOV-620 Fix events on content blocks * SIT-794 Campsite form post launch tweaks (#2689) * SIT-794 post launch tweaks: fixed typo in vehicle conf block, updated ZD handler to send anonymous if no contact email provided, removed email requirement, made sure autocomplete is off for fields except contact, add campsite_in_park tag and change group for Ranger campsite tickets, updated IRP handler to use Developer form * SIT-794 updated next steps block in park maintenance form to use Report a Campsite service link now that the new form is live * SIT-794 add IRP ticket id to AbAuto, Parks, and ADA tickets; update ADA questions; make email required if requesting accommodation * SIT-794 add IRP ticket id to AbAuto, Parks, and ADA tickets; update ADA questions; make email required if requesting accommodation * SIT-794 add campsite tag to AbAutos test tickets * SIT-794 changed order of answers on ADA accomodation field * SIT-794 switched ADA question order * SIT-794 updated zendesk handler to check for ticket ID from previous handler submission * SIT-794 removed extra spaces * SIT-794 removed space * SIT-794 add hash symbol before campsite report ticket ID in ADA tickets, so that Zendesk turns it into a link * SIT-794 changed value of new ADA option to 'no report' * SIT-794 hide zendesk ticket ID field in CSUO block * SIT-794 fix typo * SIT-794 removed public records statement from ADA accommodation form * SIT-794 demographics hotfix * SIT-794 fix anon email --------- Co-authored-by: Oden <hello@odensc.com> * PGOV-1025 Make "Online Application" field on services translatable (#2690) * SIT-784 towing complaint form updates v1.1 (#2692) * SIT-784 towing complaint form updates v1.1 * SIT-784 make employee email readonly and fix support agent field permissions * SIT-848 disable campsite confirmation email handler if anonymous (#2693) * SIT-848 disable campsite confirmation email handler if report filed anonymously * SIT-848 fixed typo in auto confirmation * SIT-845 add boundary and incident layer to hazardous tree form + towing complaints v1.1 (#2695) * SIT-845 add boundary and incident layer to hazardous tree form * SIT-845 change marker icon * SIT-845 remove pager * SIT-845 ticket description formatting, out of bounds message, & more custom fields * SIT-845 remove "none" empty value from standard unit type field Prior behavior causes any usage of the token to show "none" when the address has no unit number. Instead we can just check for an empty string. * PGOV-1032 Create new "code review" state in council document workflow (#2697) * PGOV-1032 Create new "code review" state in council document workflow Functionally identical to the "council clerk review" state, so we copy the same transitios and permission setup, and then add "code review" to any transitions where "council clerk review" was allowed. * PGOV-1032 Add new state to notify_reviewer * PGOV-1031 Update core to 10.1.7 and update modules (#2691) * PGOV-1031 Update core to 10.1.7. Update all modules except entity_browser * PGOV-1031 Disable rendering on field_geolocation_1 * PGOV-1031 Update to Core 10.2.0 * PGOV-1031 Export config after Core 10.2 update * PGOV-1031 Patch entity_browser_table * PGOV-1031 Update "drupal/csv_serialization" to 4.0 * PGOV-1031 Remove the Project Map view * PGOV-1037 Skip the site status test until CKEditor is updated (#2699) * SIT-917 add road condition field (#2702) * CS-188 add friendly permit type/reason and fix side-by-side button display * CS-188 fix confirmation message typos * PGOV-1040 Drupal 10.2.2 update / module updates * CS-188 update permit type names * CS-188 changes to support more zendesk custom fields * CS-188 revert unnecessary changes to other webforms * CS-188 add permit type to ticket subject * CS-188 fix config conflict --------- Co-authored-by: Oden <hello@odensc.com> Co-authored-by: Casey Cushing <42975136+ccdatapdx@users.noreply.github.com> Co-authored-by: kxwang <xinju.wang@portlandoregon.gov> Co-authored-by: Richard Davies <richard.davies@portlandoregon.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added setTimeout loop to verify layers are loaded before trying to determine whether clicks are inside them.
Added ajax loading indicator.